Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/cronet/android/test/javaperftests/run.py

Issue 1945023004: [Cronet] run pylint in Cronet presubmit check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/test/javaperftests/android_rndis_forwarder.py ('k') | components/cronet/pylintrc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javaperftests/run.py
diff --git a/components/cronet/android/test/javaperftests/run.py b/components/cronet/android/test/javaperftests/run.py
index 172390185b538e63ef0008c39d8768ca306af7b2..db3bf757c549405854ad0ee8218bb488e85796e9 100755
--- a/components/cronet/android/test/javaperftests/run.py
+++ b/components/cronet/android/test/javaperftests/run.py
@@ -109,7 +109,9 @@ BENCHMARK_CONFIG = {
}
# Add benchmark config to global state for easy access.
globals().update(BENCHMARK_CONFIG)
-
+# Pylint doesn't really interpret the file, so it won't find the definitions
+# added from BENCHMARK_CONFIG, so suppress the undefined variable warning.
+#pylint: disable=undefined-variable
def GetDevice():
devices = device_utils.DeviceUtils.HealthyDevices()
@@ -208,7 +210,7 @@ class CronetPerfTestBenchmark(benchmark.Benchmark):
return CronetPerfTestStorySet(self._device)
-class QuicServer:
+class QuicServer(object):
def __init__(self, quic_server_doc_root):
self._process = None
@@ -253,7 +255,7 @@ def GenerateHttpTestResources():
large_file_name = os.path.join(http_server_doc_root, LARGE_RESOURCE)
large_file = open(large_file_name, 'wb')
large_file.write('<html><body>');
- for i in range(0, 1000000):
+ for _ in range(0, 1000000):
large_file.write('1234567890');
large_file.write('</body></html>');
large_file.close()
« no previous file with comments | « components/cronet/android/test/javaperftests/android_rndis_forwarder.py ('k') | components/cronet/pylintrc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698