Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: components/cronet/PRESUBMIT.py

Issue 1945023004: [Cronet] run pylint in Cronet presubmit check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/test/javaperftests/android_rndis_forwarder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/PRESUBMIT.py
diff --git a/components/cronet/PRESUBMIT.py b/components/cronet/PRESUBMIT.py
index c822d7691f602af03d06f8b6d316f9a4e9cd0cd0..57cb261d6034d22d604a1c63ed3a9570cf1bec7a 100644
--- a/components/cronet/PRESUBMIT.py
+++ b/components/cronet/PRESUBMIT.py
@@ -8,5 +8,32 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools.
"""
+def _PyLintChecks(input_api, output_api):
+ pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api,
+ extra_paths_list=_GetPathsToPrepend(input_api), pylintrc='pylintrc')
+ return input_api.RunTests(pylint_checks)
+
+def _GetPathsToPrepend(input_api):
+ current_dir = input_api.PresubmitLocalPath()
+ chromium_src_dir = input_api.os_path.join(current_dir, '..', '..')
+ return [
+ input_api.os_path.join(current_dir, 'tools'),
+ input_api.os_path.join(current_dir, 'android', 'test', 'javaperftests'),
+ input_api.os_path.join(chromium_src_dir, 'tools', 'perf'),
+ input_api.os_path.join(chromium_src_dir, 'build', 'android'),
+ input_api.os_path.join(chromium_src_dir, 'build', 'android', 'gyp', 'util'),
+ input_api.os_path.join(chromium_src_dir, 'net', 'tools', 'net_docs'),
+ input_api.os_path.join(chromium_src_dir, 'tools'),
+ input_api.os_path.join(chromium_src_dir, 'third_party'),
+ input_api.os_path.join(chromium_src_dir,
+ 'third_party', 'catapult', 'telemetry'),
+ input_api.os_path.join(chromium_src_dir,
+ 'third_party', 'catapult', 'devil'),
+ ]
+
def CheckChangeOnUpload(input_api, output_api):
- return input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
+ results = []
+ results.extend(_PyLintChecks(input_api, output_api))
+ results.extend(
+ input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
+ return results
« no previous file with comments | « no previous file | components/cronet/android/test/javaperftests/android_rndis_forwarder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698