Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1944603003: Make AnimationEffectReadOnly.getComputedTiming() consistent with Web Animations spec (Closed)

Created:
4 years, 7 months ago by alancutter (OOO until 2018)
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make AnimationEffectReadOnly.getComputedTiming() consistent with Web Animations spec This patch changes the AnimationEffectReadOnly interface to have a getComputedTiming() method instead of a computedTiming attribute: https://w3c.github.io/web-animations/#dom-animationeffectreadonly-getcomputedtiming This also updates the returned ComputedTimingProperties dictionary members to match spec: https://w3c.github.io/web-animations/#the-computedtimingproperties-dictionary BUG=600248 Committed: https://crrev.com/cd3a7885f9c5c7ca6e209142af3f73be6ef5d375 Cr-Commit-Position: refs/heads/master@{#391750}

Patch Set 1 #

Patch Set 2 : Update expectations #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Explicitly set properties to null #

Total comments: 1

Patch Set 5 : Update interface listing #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -297 lines) Patch
M third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/delay-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/duration-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/easing-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/fill-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/iterationStart-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/iterations-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/discrete-animation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/finish-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/keyframe-effect/effect-easing-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-currentIteration-expected.txt View 1 1 chunk +37 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress-expected.txt View 1 1 chunk +37 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/web-animations-api/timed-item.html View 1 2 1 chunk +19 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffect.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffect.cpp View 1 2 3 5 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectTest.cpp View 41 chunks +72 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ComputedTimingProperties.idl View 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InertEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
alancutter (OOO until 2018)
https://codereview.chromium.org/1944603003/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/timed-item-expected.txt File third_party/WebKit/LayoutTests/web-animations-api/timed-item-expected.txt (right): https://codereview.chromium.org/1944603003/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/timed-item-expected.txt#newcode6 third_party/WebKit/LayoutTests/web-animations-api/timed-item-expected.txt:6: FAIL TimedItem startTime, endTime, duration, activeDuration are sensible for ...
4 years, 7 months ago (2016-05-03 04:20:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603003/20001
4 years, 7 months ago (2016-05-03 04:20:27 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/1944603003/diff/60001/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress-expected.txt File third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress-expected.txt (right): https://codereview.chromium.org/1944603003/diff/60001/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress-expected.txt#newcode2 third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress-expected.txt:2: FAIL Test progress during before and after phase when ...
4 years, 7 months ago (2016-05-03 05:07:34 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603003/60001
4 years, 7 months ago (2016-05-03 05:08:17 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/221239)
4 years, 7 months ago (2016-05-03 06:38:14 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603003/100001
4 years, 7 months ago (2016-05-03 08:19:08 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 10:50:50 UTC) #15
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 7 months ago (2016-05-03 23:38:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603003/100001
4 years, 7 months ago (2016-05-03 23:48:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/177174)
4 years, 7 months ago (2016-05-04 00:00:38 UTC) #20
alancutter (OOO until 2018)
+pfeldman for core/inspector/InspectorAnimationAgent.cpp change.
4 years, 7 months ago (2016-05-04 00:22:54 UTC) #22
pfeldman
lgtm
4 years, 7 months ago (2016-05-04 23:02:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603003/100001
4 years, 7 months ago (2016-05-05 01:02:54 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-05 03:53:59 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 03:55:38 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/cd3a7885f9c5c7ca6e209142af3f73be6ef5d375
Cr-Commit-Position: refs/heads/master@{#391750}

Powered by Google App Engine
This is Rietveld 408576698