Make nullable members of IDL dictionaries contain null in JS when unset

Make nullable members of IDL dictionaries contain null in JS when unset

This change updates our IDL binding code for dictionaries.
Nullable member types should convert to null if no value is set on them
from C++.
https://www.w3.org/TR/WebIDL/#es-nullable-type

BUG=600248
Committed: https://crrev.com/7fd8a80c83317398ae9276f76d42a2dc0b54f73a
Cr-Commit-Position: refs/heads/master@{#391993}

[alancutter (OOO until 2018), 2016-05-03 05:06:24]

alancutter@chromium.org changed reviewers:
+ bashi@chromium.org

[alancutter (OOO until 2018), 2016-05-03 05:06:31]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 05:06:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946453002/1

[commit-bot: I haz the power, 2016-05-03 05:10:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 05:10:56]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2016-05-03 05:22:47]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-05-03 05:22:48]

https://codereview.chromium.org/1946453002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp (right):

https://codereview.chromium.org/1946453002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp:122: if
(!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentContext(),
v8String(isolate, "{{member.name}}"), Null(isolate))))

Do you mean v8::Null?

[alancutter (OOO until 2018), 2016-05-03 05:43:39]

On 2016/05/03 at 05:22:48, haraken wrote:
>
https://codereview.chromium.org/1946453002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp (right):
> 
>
https://codereview.chromium.org/1946453002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp:122: if
(!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentContext(),
v8String(isolate, "{{member.name}}"), Null(isolate))))
> 
> Do you mean v8::Null?

Thanks, I wonder why it worked fine for me locally.

[alancutter (OOO until 2018), 2016-05-03 05:43:46]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 05:43:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946453002/20001

[commit-bot: I haz the power, 2016-05-03 05:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 05:46:07]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[haraken, 2016-05-03 05:48:15]

LGTM assuming the bots are green.

[alancutter (OOO until 2018), 2016-05-03 08:24:19]

On 2016/05/03 at 05:48:15, haraken wrote:
> LGTM assuming the bots are green.

Thanks, looks like the bots are red due to crbug.com/608637.

[alancutter (OOO until 2018), 2016-05-05 04:23:06]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-05-05 04:23:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946453002/20001

[commit-bot: I haz the power, 2016-05-05 05:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 05:29:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2016-05-05 05:37:26]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-05-05 05:37:27]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1946453002/#ps40001
(title: "Fix test")

[commit-bot: I haz the power, 2016-05-05 05:37:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946453002/40001

[commit-bot: I haz the power, 2016-05-05 08:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 08:37:06]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alancutter (OOO until 2018), 2016-05-06 01:32:24]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-05-06 01:32:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946453002/40001

[commit-bot: I haz the power, 2016-05-06 02:43:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-06 02:45:28]

Description was changed from

==========
Make nullable members of IDL dictionaries contain null in JS when unset

This change updates our IDL binding code for dictionaries.
Nullable member types should convert to null if no value is set on them
from C++.
https://www.w3.org/TR/WebIDL/#es-nullable-type

BUG=600248
==========

to

==========
Make nullable members of IDL dictionaries contain null in JS when unset

This change updates our IDL binding code for dictionaries.
Nullable member types should convert to null if no value is set on them
from C++.
https://www.w3.org/TR/WebIDL/#es-nullable-type

BUG=600248

Committed: https://crrev.com/7fd8a80c83317398ae9276f76d42a2dc0b54f73a
Cr-Commit-Position: refs/heads/master@{#391993}
==========

[commit-bot: I haz the power, 2016-05-06 02:45:29]

Patchset 3 (id:??) landed as
https://crrev.com/7fd8a80c83317398ae9276f76d42a2dc0b54f73a
Cr-Commit-Position: refs/heads/master@{#391993}