Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1944593002: DevTools: [SASS] extract exact property name and value ranges (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2-switch-css
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] extract exact property name and value ranges The patch starts extracting exact property name and value ranges, which makes it possible to link sourceMap entries based on the text node start position. BUG=608097 R=pfeldman Committed: https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52 Cr-Commit-Position: refs/heads/master@{#391443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -133 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-1-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-2-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-editing-1-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-1-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-2-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-4-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-7-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-edit-insert-property-expected.txt View 10 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSourceMapFactory.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
lushnikov
please, take a look!
4 years, 7 months ago (2016-05-03 01:58:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944593002/1
4 years, 7 months ago (2016-05-03 01:59:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 03:33:53 UTC) #5
pfeldman
lgtm
4 years, 7 months ago (2016-05-03 17:56:23 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1941283002 Patch 1). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-03 23:51:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944593002/1
4 years, 7 months ago (2016-05-04 03:10:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 04:29:04 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 04:30:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e98d06e71e63bebefcc8b5075895680925afc52
Cr-Commit-Position: refs/heads/master@{#391443}

Powered by Google App Engine
This is Rietveld 408576698