Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js

Issue 1944593002: DevTools: [SASS] extract exact property name and value ranges (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2-switch-css
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js
diff --git a/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js b/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js
index ec42c123669d6cf882705060d9abf5480676de9c..ae7eac9225c5a83217c04e0d83f82fa3da7d753a 100644
--- a/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js
+++ b/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js
@@ -71,13 +71,12 @@ WebInspector.SCSSParser.prototype = {
_handleDeclaration: function(node, output)
{
var propertyNode = node.content.find(node => node.type === "property");
- var delimeterNode = node.content.find(node => node.type === "propertyDelimiter");
var valueNode = node.content.find(node => node.type === "value");
- if (!propertyNode || !delimeterNode || !valueNode)
+ if (!propertyNode || !valueNode)
return;
- var nameRange = new WebInspector.TextRange(propertyNode.start.line - 1, propertyNode.start.column - 1, delimeterNode.start.line - 1, delimeterNode.start.column - 1);
- var valueRange = new WebInspector.TextRange(delimeterNode.end.line - 1, delimeterNode.end.column, valueNode.end.line - 1, valueNode.end.column);
+ var nameRange = WebInspector.SCSSParser.rangeFromNode(propertyNode);
+ var valueRange = WebInspector.SCSSParser.rangeFromNode(valueNode);
var range = /** @type {!WebInspector.TextRange} */(node.declarationRange);
var property = new WebInspector.SCSSParser.Property(range, nameRange, valueRange, false);

Powered by Google App Engine
This is Rietveld 408576698