Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1941283002: DevTools: [SASS] start parsing CSS with SCSS parser (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1-scss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] start parsing CSS with SCSS parser As CSS is a subset of SCSS, we can just parse CSS with the SCSS parser. BUG=608097 R=pfeldman Committed: https://crrev.com/09f3f7b5ab511baa8f4e594736251b2e25ef107a Cr-Commit-Position: refs/heads/master@{#391414}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -58 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sass/sass-test.js View 2 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3-expected.txt View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-editing-1-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/ASTService.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js View 1 chunk +0 lines, -37 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
lushnikov
ptal
4 years, 7 months ago (2016-05-03 01:45:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941283002/1
4 years, 7 months ago (2016-05-03 01:46:09 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 02:54:02 UTC) #5
pfeldman
lgtm
4 years, 7 months ago (2016-05-03 17:56:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941283002/1
4 years, 7 months ago (2016-05-03 23:17:05 UTC) #8
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-04 00:04:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941283002/20001
4 years, 7 months ago (2016-05-04 00:30:22 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 02:14:25 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 02:15:32 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09f3f7b5ab511baa8f4e594736251b2e25ef107a
Cr-Commit-Position: refs/heads/master@{#391414}

Powered by Google App Engine
This is Rietveld 408576698