Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1935403002: DevTools: [SASS] CSSRule supports selector text nodes (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@3-precise-mapping
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] CSSRule supports selector text nodes This patch adds selectors as a text nodes into AST tree. As a result, this patch starts displaying rule locations as *.scss in Styles Sidebar Pane. BUG=608097 R=pfeldman Committed: https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080 Cr-Commit-Position: refs/heads/master@{#391460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sass/sass-test.js View 3 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-1-expected.txt View 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-2-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-css-3-expected.txt View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-1-expected.txt View 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-2-expected.txt View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3-expected.txt View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-4-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5-expected.txt View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-7-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-mapping-good-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-mapping-many-scss-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js View 5 chunks +14 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935403002/1
4 years, 7 months ago (2016-05-03 02:22:45 UTC) #2
lushnikov
ptal
4 years, 7 months ago (2016-05-03 02:24:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 03:43:16 UTC) #5
pfeldman
lgtm
4 years, 7 months ago (2016-05-03 17:56:38 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1944593002 Patch 1). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-03 23:52:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935403002/1
4 years, 7 months ago (2016-05-04 04:31:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/156219)
4 years, 7 months ago (2016-05-04 05:03:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935403002/1
4 years, 7 months ago (2016-05-04 05:30:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 08:19:55 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 08:21:21 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16c34c8a98f1ea2e83bed8ab130ec12bcae9e080
Cr-Commit-Position: refs/heads/master@{#391460}

Powered by Google App Engine
This is Rietveld 408576698