Ctrl/Alt+Enter shouldn't insert newline

Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
Committed: https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e
Cr-Commit-Position: refs/heads/master@{#392566}

[chongz, 2016-05-02 19:57:40]

Description was changed from

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux.

According to discussion in b/28224354 Ctrl+Enter often gets used as
shortcuts in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
Internal=b/28224354
==========

to

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion in b/28224354 Ctrl+Enter often gets used as
shortcuts in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
Internal=b/28224354
==========

[chongz, 2016-05-02 22:01:42]

chongz@chromium.org changed reviewers:
+ yutak@chromium.org

[chongz, 2016-05-02 22:01:42]

Hi yutak@, can you take a look at this CL please? Thanks!

[chongz, 2016-05-02 22:05:09]

Patchset #2 (id:20001) has been deleted

[Yuta Kitamura, 2016-05-06 07:22:19]

yutak@chromium.org changed reviewers:
+ yosin@chromium.org

[Yuta Kitamura, 2016-05-06 07:22:20]

+yosin

[yosin_UTC9, 2016-05-09 03:52:51]

I think we don't need to put internal bug number here.

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html
(right):

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html:13:
document.write('This test requires eventSender');
nit: Use |return| to avoid else-clauses to reduce indentation.

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
(right):

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html:16:
performJumpAtTheEdgeTest(false);
Could you change |performJumpAtTheEdgeTest()| to take no parameter?
Because all call sites pass false, and we don't support Ctrl+Enter anymore to
insert newline anymore.

[chongz, 2016-05-09 14:08:59]

Description was changed from

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion in b/28224354 Ctrl+Enter often gets used as
shortcuts in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
Internal=b/28224354
==========

to

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion in b/28224354 Ctrl+Enter often gets used as
shortcuts in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

[chongz, 2016-05-09 21:21:02]

Yosin@ I've removed internal bug number and updated CL as per your comments,
PTAL. Thanks!

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html
(right):

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html:13:
document.write('This test requires eventSender');
On 2016/05/09 03:52:51, Yosi_UTC9 wrote:
> nit: Use |return| to avoid else-clauses to reduce indentation.

Done.

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
(right):

https://codereview.chromium.org/1942683004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html:16:
performJumpAtTheEdgeTest(false);
On 2016/05/09 03:52:51, Yosi_UTC9 wrote:
> Could you change |performJumpAtTheEdgeTest()| to take no parameter?
> Because all call sites pass false, and we don't support Ctrl+Enter anymore to
> insert newline anymore.

Done.

[chongz, 2016-05-09 21:21:34]

Description was changed from

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion in b/28224354 Ctrl+Enter often gets used as
shortcuts in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

to

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion in Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

[chongz, 2016-05-09 21:21:54]

Description was changed from

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion in Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

to

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

[yosin_UTC9, 2016-05-10 07:32:54]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-05-10 07:32:54]

lgtm

[commit-bot: I haz the power, 2016-05-10 07:33:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942683004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942683004/60001

[commit-bot: I haz the power, 2016-05-10 08:46:39]

Description was changed from

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

to

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

[commit-bot: I haz the power, 2016-05-10 08:46:40]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-10 08:48:38]

Description was changed from

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814
==========

to

==========
Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux (https://crbug.com/608447).

According to discussion Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG=604814

Committed: https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e
Cr-Commit-Position: refs/heads/master@{#392566}
==========

[commit-bot: I haz the power, 2016-05-10 08:48:39]

Patchset 3 (id:??) landed as
https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e
Cr-Commit-Position: refs/heads/master@{#392566}