third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html - Issue 1942683004: Ctrl/Alt+Enter shouldn't insert newline

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html

Issue 1942683004: Ctrl/Alt+Enter shouldn't insert newline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix existing tests for Ctrl/Alt Enter Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html ('K') | « third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html ('k') | third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <head>	2 <head>

3 <script type="text/javascript" src="resources/reveal-utilities.js"></script>	3 <script type="text/javascript" src="resources/reveal-utilities.js"></script>

4 </head>	4 </head>

5 <body>	5 <body>

6 <div>When the caret is scrolled out and resides at the end of the contenteditabl e,	6 <div>When the caret is scrolled out and resides at the end of the contenteditabl e,

7 on pressing "Ctrl+Return" it must be scrolled to the bottom of the vie w,	7 on pressing "Return" it must be scrolled to the bottom of the view,

8 not to the center to avoid undesirable content view jumping.</div>	8 not to the center to avoid undesirable content view jumping.</div>

9 <div style="height:1000px;">	9 <div style="height:1000px;">

10 <div style="overflow:visible; height:100px;" contenteditable="true" id="input" ></div>	10 <div style="overflow:visible; height:100px;" contenteditable="true" id="input" ></div>

11 </div>	11 </div>

12 <script>	12 <script>

13 if (window.testRunner)	13 if (window.testRunner)

14 testRunner.dumpAsText();	14 testRunner.dumpAsText();

15	15

16 performJumpAtTheEdgeTest(true);	16 performJumpAtTheEdgeTest(false);
	yosin_UTC9 2016/05/09 03:52:51 Could you change \|performJumpAtTheEdgeTest()\| to t Could you change \|performJumpAtTheEdgeTest()\| to take no parameter? Because all call sites pass false, and we don't support Ctrl+Enter anymore to insert newline anymore. chongz 2016/05/09 21:21:01 Done. Show quoted text On 2016/05/09 03:52:51, Yosi_UTC9 wrote: > Could you change \|performJumpAtTheEdgeTest()\| to take no parameter? > Because all call sites pass false, and we don't support Ctrl+Enter anymore to > insert newline anymore. Done.
17	17

18 </script>	18 </script>

19 </body>	19 </body>

OLD	NEW