third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js - Issue 1942683004: Ctrl/Alt+Enter shouldn't insert newline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js

Issue 1942683004: Ctrl/Alt+Enter shouldn't insert newline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Yosin's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html ('k') | third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js

diff --git a/third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js b/third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js

index c668b35e1e0087b8577e82ece7d529e60301b36b..06073a160346b0786a754d16ac97c6c18ba948a2 100644

--- a/third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js

+++ b/third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js

@@ -65,7 +65,7 @@ function performVerticalScrollingPasteTest()

}

-function performJumpAtTheEdgeTest(useCtrlKeyModifier)

+function performJumpAtTheEdgeTest()

{

var textArea = document.getElementById("input");

textArea.focus();

@@ -74,7 +74,7 @@ function performJumpAtTheEdgeTest(useCtrlKeyModifier)

var jumpDetected = false;

for (var i = 0; i < 120; ++i) {

previousScrollTop = document.documentElement.scrollTop;

- eventSender.keyDown("\r", useCtrlKeyModifier ? ["ctrlKey"] : []);

+ eventSender.keyDown("\r", []);

currentScrollTop = document.documentElement.scrollTop;

// Smooth scrolls are allowed.

if (Math.abs(previousScrollTop - currentScrollTop) > 24) {