third_party/WebKit/Source/core/editing/EditingBehavior.cpp - Issue 1942683004: Ctrl/Alt+Enter shouldn't insert newline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingBehavior.cpp

Issue 1942683004: Ctrl/Alt+Enter shouldn't insert newline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Yosin's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingBehavior.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingBehavior.cpp b/third_party/WebKit/Source/core/editing/EditingBehavior.cpp

index 8e9fe097f4e392efcc1b33c831611173e44d6d66..39922f8fc5a2cacb16f26540ccbc2f7feea0e2a4 100644

--- a/third_party/WebKit/Source/core/editing/EditingBehavior.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingBehavior.cpp

@@ -173,10 +173,7 @@ static const KeyPressEntry keyPressEntries[] = {

{ '\t', 0, "InsertTab" },

{ '\t', ShiftKey, "InsertBacktab" },

{ '\r', 0, "InsertNewline" },

- { '\r', CtrlKey, "InsertNewline" },

{ '\r', ShiftKey, "InsertLineBreak" },

- { '\r', AltKey, "InsertNewline" },

- { '\r', AltKey | ShiftKey, "InsertNewline" },

};

const char* EditingBehavior::interpretKeyEvent(const KeyboardEvent& event) const