Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1940153003: Remove references to 'chrome_build_id' (Closed)

Created:
4 years, 7 months ago by Yaron
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to 'chrome_build_id' These were an artifact of meeting licensing requirements in order to find build artifacts for a deployed chrome. As of https://codereview.chromium.org/1948503002/ the code will be entirely open-source so this is unnecessary. BUG=607207 Committed: https://crrev.com/9b4327b53bcdda11fabf73e5c1d791bcfeac98b2 Cr-Commit-Position: refs/heads/master@{#391535}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/crash/content/app/breakpad_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/version_ui/version_ui_constants.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/version_ui/version_ui_constants.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/version_ui_strings.grdp View 1 chunk +0 lines, -5 lines 0 comments Download
M docs/android_build_instructions.md View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Yaron
4 years, 7 months ago (2016-05-03 16:44:48 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-04 10:51:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940153003/20001
4 years, 7 months ago (2016-05-04 15:39:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 16:36:34 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 16:37:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b4327b53bcdda11fabf73e5c1d791bcfeac98b2
Cr-Commit-Position: refs/heads/master@{#391535}

Powered by Google App Engine
This is Rietveld 408576698