Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/ui/webui/version_ui.cc

Issue 1940153003: Remove references to 'chrome_build_id' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/version_ui.h" 5 #include "chrome/browser/ui/webui/version_ui.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL); 62 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL);
63 html_source->AddString(version_ui::kOSType, version_info::GetOSType()); 63 html_source->AddString(version_ui::kOSType, version_info::GetOSType());
64 html_source->AddString(version_ui::kBlinkVersion, 64 html_source->AddString(version_ui::kBlinkVersion,
65 content::GetWebKitVersion()); 65 content::GetWebKitVersion());
66 html_source->AddString(version_ui::kJSEngine, "V8"); 66 html_source->AddString(version_ui::kJSEngine, "V8");
67 html_source->AddString(version_ui::kJSVersion, v8::V8::GetVersion()); 67 html_source->AddString(version_ui::kJSVersion, v8::V8::GetVersion());
68 68
69 #if defined(OS_ANDROID) 69 #if defined(OS_ANDROID)
70 html_source->AddString(version_ui::kOSVersion, 70 html_source->AddString(version_ui::kOSVersion,
71 AndroidAboutAppInfo::GetOsInfo()); 71 AndroidAboutAppInfo::GetOsInfo());
72 html_source->AddLocalizedString(version_ui::kBuildIDName,
73 IDS_VERSION_UI_BUILD_ID);
74 html_source->AddString(version_ui::kBuildID, CHROME_BUILD_ID);
75 #else 72 #else
76 html_source->AddString(version_ui::kOSVersion, std::string()); 73 html_source->AddString(version_ui::kOSVersion, std::string());
77 html_source->AddString(version_ui::kFlashPlugin, "Flash"); 74 html_source->AddString(version_ui::kFlashPlugin, "Flash");
78 // Note that the Flash version is retrieve asynchronously and returned in 75 // Note that the Flash version is retrieve asynchronously and returned in
79 // VersionHandler::OnGotPlugins. The area is initially blank. 76 // VersionHandler::OnGotPlugins. The area is initially blank.
80 html_source->AddString(version_ui::kFlashVersion, std::string()); 77 html_source->AddString(version_ui::kFlashVersion, std::string());
81 #endif // defined(OS_ANDROID) 78 #endif // defined(OS_ANDROID)
82 79
83 html_source->AddLocalizedString(version_ui::kCompany, 80 html_source->AddLocalizedString(version_ui::kCompany,
84 IDS_ABOUT_VERSION_COMPANY_NAME); 81 IDS_ABOUT_VERSION_COMPANY_NAME);
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 // Set up the chrome://theme/ source. 172 // Set up the chrome://theme/ source.
176 ThemeSource* theme = new ThemeSource(profile); 173 ThemeSource* theme = new ThemeSource(profile);
177 content::URLDataSource::Add(profile, theme); 174 content::URLDataSource::Add(profile, theme);
178 #endif 175 #endif
179 176
180 WebUIDataSource::Add(profile, CreateVersionUIDataSource()); 177 WebUIDataSource::Add(profile, CreateVersionUIDataSource());
181 } 178 }
182 179
183 VersionUI::~VersionUI() { 180 VersionUI::~VersionUI() {
184 } 181 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698