Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: build/common.gypi

Issue 1940153003: Remove references to 'chrome_build_id' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/config.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 641cc709fcb5ecc1c39c80d1e06ddd968f649650..f1805f8b521a587c65b3ee14dcfd4069a446ed47 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -4722,11 +4722,6 @@
# Android-specific options; note that most are set above with Linux.
['OS=="android"', {
'variables': {
- # This is a unique identifier for a given build. It's used for
- # identifying various build artifacts corresponding to a particular
- # build of chrome (e.g. where to find archived symbols).
- 'chrome_build_id%': '',
-
# Placing this variable here prevents from forking libvpx, used
# by remoting. Remoting is off, so it needn't built,
# so forking it's deps seems like overkill.
@@ -4816,7 +4811,6 @@
'defines': [
'ANDROID',
'__GNU_SOURCE=1', # Necessary for clone()
- 'CHROME_BUILD_ID="<(chrome_build_id)"',
# The NDK has these things, but doesn't define the constants
# to say that it does. Define them here instead.
'HAVE_SYS_UIO_H',
« no previous file with comments | « no previous file | build/config/android/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698