Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: build/common.gypi

Issue 1940153003: Remove references to 'chrome_build_id' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/config.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4704 matching lines...) Expand 10 before | Expand all | Expand 10 after
4715 ['OS=="freebsd"', { 4715 ['OS=="freebsd"', {
4716 'target_defaults': { 4716 'target_defaults': {
4717 'ldflags': [ 4717 'ldflags': [
4718 '-Wl,--no-keep-memory', 4718 '-Wl,--no-keep-memory',
4719 ], 4719 ],
4720 }, 4720 },
4721 }], 4721 }],
4722 # Android-specific options; note that most are set above with Linux. 4722 # Android-specific options; note that most are set above with Linux.
4723 ['OS=="android"', { 4723 ['OS=="android"', {
4724 'variables': { 4724 'variables': {
4725 # This is a unique identifier for a given build. It's used for
4726 # identifying various build artifacts corresponding to a particular
4727 # build of chrome (e.g. where to find archived symbols).
4728 'chrome_build_id%': '',
4729
4730 # Placing this variable here prevents from forking libvpx, used 4725 # Placing this variable here prevents from forking libvpx, used
4731 # by remoting. Remoting is off, so it needn't built, 4726 # by remoting. Remoting is off, so it needn't built,
4732 # so forking it's deps seems like overkill. 4727 # so forking it's deps seems like overkill.
4733 # But this variable need defined to properly run gyp. 4728 # But this variable need defined to properly run gyp.
4734 # A proper solution is to have an OS==android conditional 4729 # A proper solution is to have an OS==android conditional
4735 # in third_party/libvpx/libvpx.gyp to define it. 4730 # in third_party/libvpx/libvpx.gyp to define it.
4736 'libvpx_path': 'lib/linux/arm', 4731 'libvpx_path': 'lib/linux/arm',
4737 }, 4732 },
4738 'target_defaults': { 4733 'target_defaults': {
4739 'variables': { 4734 'variables': {
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
4809 # cflags rather than include_dirs because they need to come 4804 # cflags rather than include_dirs because they need to come
4810 # after include_dirs. 4805 # after include_dirs.
4811 # The include ordering here is important; change with caution. 4806 # The include ordering here is important; change with caution.
4812 '-isystem<(android_libcpp_include)', 4807 '-isystem<(android_libcpp_include)',
4813 '-isystem<(android_ndk_root)/sources/cxx-stl/llvm-libc++abi/libcxx abi/include', 4808 '-isystem<(android_ndk_root)/sources/cxx-stl/llvm-libc++abi/libcxx abi/include',
4814 '-isystem<(android_ndk_root)/sources/android/support/include', 4809 '-isystem<(android_ndk_root)/sources/android/support/include',
4815 ], 4810 ],
4816 'defines': [ 4811 'defines': [
4817 'ANDROID', 4812 'ANDROID',
4818 '__GNU_SOURCE=1', # Necessary for clone() 4813 '__GNU_SOURCE=1', # Necessary for clone()
4819 'CHROME_BUILD_ID="<(chrome_build_id)"',
4820 # The NDK has these things, but doesn't define the constants 4814 # The NDK has these things, but doesn't define the constants
4821 # to say that it does. Define them here instead. 4815 # to say that it does. Define them here instead.
4822 'HAVE_SYS_UIO_H', 4816 'HAVE_SYS_UIO_H',
4823 ], 4817 ],
4824 'ldflags!': [ 4818 'ldflags!': [
4825 '-pthread', # Not supported by Android toolchain. 4819 '-pthread', # Not supported by Android toolchain.
4826 ], 4820 ],
4827 'ldflags': [ 4821 'ldflags': [
4828 '-Wl,--build-id=sha1', 4822 '-Wl,--build-id=sha1',
4829 '-Wl,--no-undefined', 4823 '-Wl,--no-undefined',
(...skipping 1498 matching lines...) Expand 10 before | Expand all | Expand 10 after
6328 # settings in target dicts. SYMROOT is a special case, because many other 6322 # settings in target dicts. SYMROOT is a special case, because many other
6329 # Xcode variables depend on it, including variables such as 6323 # Xcode variables depend on it, including variables such as
6330 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6324 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6331 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6325 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6332 # files to appear (when present) in the UI as actual files and not red 6326 # files to appear (when present) in the UI as actual files and not red
6333 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6327 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6334 # and therefore SYMROOT, needs to be set at the project level. 6328 # and therefore SYMROOT, needs to be set at the project level.
6335 'SYMROOT': '<(DEPTH)/xcodebuild', 6329 'SYMROOT': '<(DEPTH)/xcodebuild',
6336 }, 6330 },
6337 } 6331 }
OLDNEW
« no previous file with comments | « no previous file | build/config/android/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698