cc: Move prepaint region calculations to the tiling set.

cc: Move prepaint region calculations to the tiling set.

This patch moves prepaint region calculations from the tiling to the
tiling set. This ensures that new tilings get proper skewport
information. It also allows us to retrieve prepaint regions
independently of tilings present, which is useful for iterating images.

R=enne, danakj
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cf1113301b3c251c09ac7f7576b4f98bebf64f25
Cr-Commit-Position: refs/heads/master@{#391645}

[vmpstr, 2016-05-02 20:45:55]

Description was changed from

==========
cc: Move prepaint region calculations to the tiling set.

This patch moves prepaint region calculations from the tiling to the
tiling set. This ensures that new tilings get proper skewport
information. It also allows us to retrieve prepaint regions
independently of tilings present, which is useful for iterating images.

R=enne, danakj
==========

to

==========
cc: Move prepaint region calculations to the tiling set.

This patch moves prepaint region calculations from the tiling to the
tiling set. This ensures that new tilings get proper skewport
information. It also allows us to retrieve prepaint regions
independently of tilings present, which is useful for iterating images.

R=enne, danakj
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[vmpstr, 2016-05-02 20:48:27]

Please take a look.

[enne (OOO), 2016-05-03 23:03:02]

lgtm

I think having all this history and some rect calculations on the tiling set
makes a lot more sense than doing it per tiling anyway.

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:557: std::vector<gfx::Rect> output_rects;
Premature optimization, but like...do we really need an allocation here? Just
loop 0 to arraysize - 1 on a fixed array.  :P

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_set.h (right):

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_set.h:187: class AutoClear {
I kinda think a state class with an autoclear subclass might be overkill for a
single function with a single early out, but it's fine to leave.

[vmpstr, 2016-05-03 23:31:59]

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:557: std::vector<gfx::Rect> output_rects;
On 2016/05/03 23:03:01, enne wrote:
> Premature optimization, but like...do we really need an allocation here? Just
> loop 0 to arraysize - 1 on a fixed array.  :P

I went with a vector here to avoid default initializing 4 rects as a premature
optimization :P

I changed it to an array since it's more clear what's going on.

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_set.h (right):

https://codereview.chromium.org/1939963002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_set.h:187: class AutoClear {
On 2016/05/03 23:03:01, enne wrote:
> I kinda think a state class with an autoclear subclass might be overkill for a
> single function with a single early out, but it's fine to leave.

Acknowledged.

[vmpstr, 2016-05-03 23:32:04]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-05-03 23:32:04]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1939963002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-03 23:33:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1939963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1939963002/40001

[commit-bot: I haz the power, 2016-05-04 00:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:15:57]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2016-05-04 19:51:52]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-05-04 19:51:52]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1939963002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-04 19:52:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1939963002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1939963002/60001

[commit-bot: I haz the power, 2016-05-04 21:20:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-04 21:23:34]

Description was changed from

==========
cc: Move prepaint region calculations to the tiling set.

This patch moves prepaint region calculations from the tiling to the
tiling set. This ensures that new tilings get proper skewport
information. It also allows us to retrieve prepaint regions
independently of tilings present, which is useful for iterating images.

R=enne, danakj
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move prepaint region calculations to the tiling set.

This patch moves prepaint region calculations from the tiling to the
tiling set. This ensures that new tilings get proper skewport
information. It also allows us to retrieve prepaint regions
independently of tilings present, which is useful for iterating images.

R=enne, danakj
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cf1113301b3c251c09ac7f7576b4f98bebf64f25
Cr-Commit-Position: refs/heads/master@{#391645}
==========

[commit-bot: I haz the power, 2016-05-04 21:23:35]

Patchset 4 (id:??) landed as
https://crrev.com/cf1113301b3c251c09ac7f7576b4f98bebf64f25
Cr-Commit-Position: refs/heads/master@{#391645}