Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1939903002: Initialize an uninitialized variable. Move inits to header. (Closed)

Created:
4 years, 7 months ago by jdufault
Modified:
4 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize an uninitialized variable. Move inits to header. BUG=603217 Committed: https://crrev.com/2c0b1daa2b2ce2ea7f556a555f8b7098f0170373 Cr-Commit-Position: refs/heads/master@{#391666}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rework comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/browser/chromeos/login/lock/webui_screen_locker.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jdufault
Achuith, PTAL. It is a small cleanup.
4 years, 7 months ago (2016-05-02 18:20:54 UTC) #3
achuithb
lgtm. Don't feel obligated to address the comment https://codereview.chromium.org/1939903002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h File chrome/browser/chromeos/login/lock/webui_screen_locker.h (right): https://codereview.chromium.org/1939903002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h#newcode172 chrome/browser/chromeos/login/lock/webui_screen_locker.h:172: // ...
4 years, 7 months ago (2016-05-02 18:40:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939903002/20001
4 years, 7 months ago (2016-05-04 21:32:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 22:35:01 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 22:36:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c0b1daa2b2ce2ea7f556a555f8b7098f0170373
Cr-Commit-Position: refs/heads/master@{#391666}

Powered by Google App Engine
This is Rietveld 408576698