Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2716)

Unified Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.h

Issue 1939903002: Initialize an uninitialized variable. Move inits to header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Rework comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/lock/webui_screen_locker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/lock/webui_screen_locker.h
diff --git a/chrome/browser/chromeos/login/lock/webui_screen_locker.h b/chrome/browser/chromeos/login/lock/webui_screen_locker.h
index 72b55133c4cce0f1f073db06bc50c1dbd3c1de66..8fd40d98ce4d4a8b44487d0a72ed2da65876f51d 100644
--- a/chrome/browser/chromeos/login/lock/webui_screen_locker.h
+++ b/chrome/browser/chromeos/login/lock/webui_screen_locker.h
@@ -150,7 +150,7 @@ class WebUIScreenLocker : public WebUILoginView,
void ResetAndFocusUserPod();
// The screen locker window.
- views::Widget* lock_window_;
+ views::Widget* lock_window_ = nullptr;
// Sign-in Screen controller instance (owns login screens).
std::unique_ptr<SignInScreenController> signin_screen_controller_;
@@ -159,18 +159,18 @@ class WebUIScreenLocker : public WebUILoginView,
std::unique_ptr<WebUILoginDisplay> login_display_;
// Tracks when the lock window is displayed and ready.
- bool lock_ready_;
+ bool lock_ready_ = false;
// Tracks when the WebUI finishes loading.
- bool webui_ready_;
+ bool webui_ready_ = false;
// Time when lock was initiated, required for metrics.
base::TimeTicks lock_time_;
std::unique_ptr<login::NetworkStateHelper> network_state_helper_;
- // True is subscribed as keyboard controller observer.
- bool is_observing_keyboard_;
+ // True iff this object is observing a keyboard controller.
+ bool is_observing_keyboard_ = false;
base::WeakPtrFactory<WebUIScreenLocker> weak_factory_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/lock/webui_screen_locker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698