Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Side by Side Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.h

Issue 1939903002: Initialize an uninitialized variable. Move inits to header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Rework comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/lock/webui_screen_locker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WEBUI_SCREEN_LOCKER_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WEBUI_SCREEN_LOCKER_H_
6 #define CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WEBUI_SCREEN_LOCKER_H_ 6 #define CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WEBUI_SCREEN_LOCKER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 143
144 ~WebUIScreenLocker() override; 144 ~WebUIScreenLocker() override;
145 145
146 // Ensures that user pod is focused. 146 // Ensures that user pod is focused.
147 void FocusUserPod(); 147 void FocusUserPod();
148 148
149 // Reset user pod and ensures that user pod is focused. 149 // Reset user pod and ensures that user pod is focused.
150 void ResetAndFocusUserPod(); 150 void ResetAndFocusUserPod();
151 151
152 // The screen locker window. 152 // The screen locker window.
153 views::Widget* lock_window_; 153 views::Widget* lock_window_ = nullptr;
154 154
155 // Sign-in Screen controller instance (owns login screens). 155 // Sign-in Screen controller instance (owns login screens).
156 std::unique_ptr<SignInScreenController> signin_screen_controller_; 156 std::unique_ptr<SignInScreenController> signin_screen_controller_;
157 157
158 // Login UI implementation instance. 158 // Login UI implementation instance.
159 std::unique_ptr<WebUILoginDisplay> login_display_; 159 std::unique_ptr<WebUILoginDisplay> login_display_;
160 160
161 // Tracks when the lock window is displayed and ready. 161 // Tracks when the lock window is displayed and ready.
162 bool lock_ready_; 162 bool lock_ready_ = false;
163 163
164 // Tracks when the WebUI finishes loading. 164 // Tracks when the WebUI finishes loading.
165 bool webui_ready_; 165 bool webui_ready_ = false;
166 166
167 // Time when lock was initiated, required for metrics. 167 // Time when lock was initiated, required for metrics.
168 base::TimeTicks lock_time_; 168 base::TimeTicks lock_time_;
169 169
170 std::unique_ptr<login::NetworkStateHelper> network_state_helper_; 170 std::unique_ptr<login::NetworkStateHelper> network_state_helper_;
171 171
172 // True is subscribed as keyboard controller observer. 172 // True iff this object is observing a keyboard controller.
173 bool is_observing_keyboard_; 173 bool is_observing_keyboard_ = false;
174 174
175 base::WeakPtrFactory<WebUIScreenLocker> weak_factory_; 175 base::WeakPtrFactory<WebUIScreenLocker> weak_factory_;
176 176
177 DISALLOW_COPY_AND_ASSIGN(WebUIScreenLocker); 177 DISALLOW_COPY_AND_ASSIGN(WebUIScreenLocker);
178 }; 178 };
179 179
180 } // namespace chromeos 180 } // namespace chromeos
181 181
182 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WEBUI_SCREEN_LOCKER_H_ 182 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WEBUI_SCREEN_LOCKER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/lock/webui_screen_locker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698