Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.cc

Issue 1939903002: Initialize an uninitialized variable. Move inits to header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Rework comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chromeos/login/lock/webui_screen_locker.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/lock/webui_screen_locker.h" 5 #include "chrome/browser/chromeos/login/lock/webui_screen_locker.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shell.h"
8 #include "ash/system/chromeos/power/power_event_observer.h" 8 #include "ash/system/chromeos/power/power_event_observer.h"
9 #include "ash/wm/lock_state_controller.h" 9 #include "ash/wm/lock_state_controller.h"
10 #include "ash/wm/lock_state_observer.h" 10 #include "ash/wm/lock_state_observer.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 55
56 } // namespace 56 } // namespace
57 57
58 namespace chromeos { 58 namespace chromeos {
59 59
60 //////////////////////////////////////////////////////////////////////////////// 60 ////////////////////////////////////////////////////////////////////////////////
61 // WebUIScreenLocker implementation. 61 // WebUIScreenLocker implementation.
62 62
63 WebUIScreenLocker::WebUIScreenLocker(ScreenLocker* screen_locker) 63 WebUIScreenLocker::WebUIScreenLocker(ScreenLocker* screen_locker)
64 : ScreenLockerDelegate(screen_locker), 64 : ScreenLockerDelegate(screen_locker),
65 lock_ready_(false),
66 webui_ready_(false),
67 network_state_helper_(new login::NetworkStateHelper), 65 network_state_helper_(new login::NetworkStateHelper),
68 is_observing_keyboard_(false),
69 weak_factory_(this) { 66 weak_factory_(this) {
70 set_should_emit_login_prompt_visible(false); 67 set_should_emit_login_prompt_visible(false);
71 ash::Shell::GetInstance()->lock_state_controller()->AddObserver(this); 68 ash::Shell::GetInstance()->lock_state_controller()->AddObserver(this);
72 ash::Shell::GetInstance()->delegate()->AddVirtualKeyboardStateObserver(this); 69 ash::Shell::GetInstance()->delegate()->AddVirtualKeyboardStateObserver(this);
73 gfx::Screen::GetScreen()->AddObserver(this); 70 gfx::Screen::GetScreen()->AddObserver(this);
74 DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this); 71 DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this);
75 72
76 if (keyboard::KeyboardController::GetInstance()) { 73 if (keyboard::KeyboardController::GetInstance()) {
77 keyboard::KeyboardController::GetInstance()->AddObserver(this); 74 keyboard::KeyboardController::GetInstance()->AddObserver(this);
78 is_observing_keyboard_ = true; 75 is_observing_keyboard_ = true;
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 } 421 }
425 422
426 if (GetOobeUI()) { 423 if (GetOobeUI()) {
427 const gfx::Size& size = primary_display.size(); 424 const gfx::Size& size = primary_display.size();
428 GetOobeUI()->GetCoreOobeActor()->SetClientAreaSize(size.width(), 425 GetOobeUI()->GetCoreOobeActor()->SetClientAreaSize(size.width(),
429 size.height()); 426 size.height());
430 } 427 }
431 } 428 }
432 429
433 } // namespace chromeos 430 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/lock/webui_screen_locker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698