Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1938213002: [Atomics] Make Atomics.store a builtin using TF (Closed)

Created:
4 years, 7 months ago by binji
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] Make Atomics.store a builtin using TF BUG=v8:4614 R=bmeurer@chromium.org,jarin@chromium.org LOG=n Committed: https://crrev.com/81cb841170dab08e3e3bc0256e867f9de17873f5 Cr-Commit-Position: refs/heads/master@{#35993}

Patch Set 1 #

Patch Set 2 : merge master #

Patch Set 3 : merge again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -78 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 5 chunks +36 lines, -3 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/js/harmony-atomics.js View 2 chunks +0 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-atomics.cc View 5 chunks +0 lines, -59 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/atomics.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
4 years, 7 months ago (2016-05-03 00:27:25 UTC) #1
Benedikt Meurer
Awesome! LGTM.
4 years, 7 months ago (2016-05-03 04:04:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938213002/40001
4 years, 7 months ago (2016-05-03 17:24:50 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-03 17:27:16 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 17:28:41 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/81cb841170dab08e3e3bc0256e867f9de17873f5
Cr-Commit-Position: refs/heads/master@{#35993}

Powered by Google App Engine
This is Rietveld 408576698