src/compiler/mips64/code-generator-mips64.cc - Issue 1938213002: [Atomics] Make Atomics.store a builtin using TF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 1938213002: [Atomics] Make Atomics.store a builtin using TF (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: merge again Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/mips64/code-generator-mips64.cc

diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc

index 1cd51a1ccd8df145a9f102f7488d3b02229d4593..af650544ea49210358743d99d42d930187bc960c 100644

--- a/src/compiler/mips64/code-generator-mips64.cc

+++ b/src/compiler/mips64/code-generator-mips64.cc

@@ -1596,6 +1596,12 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

case kAtomicLoadWord32:

ASSEMBLE_ATOMIC_LOAD_INTEGER(lw);

break;

+ case kAtomicStoreWord8:

+ case kAtomicStoreWord16:

+ case kAtomicStoreWord32:

+ // TODO(binji): implement

+ __ nop();

+ break;

}

return kSuccess;

} // NOLINT(readability/fn_size)