Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1937173002: Revert of Pepper takes ownership of a mailbox before passing it to the texture layer. (Closed)

Created:
4 years, 7 months ago by erikchen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, piman+watch_chromium.org, darin-cc_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pepper takes ownership of a mailbox before passing it to the texture layer. (patchset #19 id:350001 of https://codereview.chromium.org/1912833002/ ) Reason for revert: Top crasher on renderer and gpu processes: https://bugs.chromium.org/p/chromium/issues/detail?id=608163 Original issue's description: > Pepper takes ownership of a mailbox before passing it to the texture layer. > > I replaced the IPC message GpuCommandBufferMsg_ProduceFrontBuffer with > GpuCommandBufferMsg_TakeFrontBuffer and GpuCommandBufferMsg_ReturnFrontBuffer. > TakeFrontBuffer gives ownership of the front buffer to the client. When the > client returns it with ReturnFrontBuffer, the command buffer may choose to reuse > it. > > This means that pepper no longer needs to use > SetTextureMailboxWithoutReleaseCallback. > > BUG=350204, 602484 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/ed5a6bb9f4321670482acc32a7cb4246a1e22f25 > Cr-Commit-Position: refs/heads/master@{#390570} TBR=ccameron@chromium.org,piman@chromium.org,bbudge@chromium.org,tsepez@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=350204, 602484 Committed: https://crrev.com/2e2db2fd684658f0c75b8ab730ac3d2cc36f9958 Cr-Commit-Position: refs/heads/master@{#390986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -441 lines) Patch
M cc/layers/texture_layer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/layers/texture_layer.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M components/mus/public/interfaces/command_buffer.mojom View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 3 chunks +3 lines, -22 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +16 lines, -44 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.h View 4 chunks +7 lines, -14 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 6 chunks +10 lines, -40 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +5 lines, -123 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/command_buffer/tests/gl_texture_mailbox_unittest.cc View 5 chunks +35 lines, -101 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 chunk +7 lines, -17 lines 0 comments Download
M gpu/ipc/common/gpu_messages.h View 1 chunk +2 lines, -9 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
erikchen
Created Revert of Pepper takes ownership of a mailbox before passing it to the texture ...
4 years, 7 months ago (2016-05-02 16:45:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937173002/1
4 years, 7 months ago (2016-05-02 16:45:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937173002/1
4 years, 7 months ago (2016-05-02 17:01:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937173002/1
4 years, 7 months ago (2016-05-02 17:32:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 17:45:58 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:47:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e2db2fd684658f0c75b8ab730ac3d2cc36f9958
Cr-Commit-Position: refs/heads/master@{#390986}

Powered by Google App Engine
This is Rietveld 408576698