Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1539)

Unified Diff: cc/layers/texture_layer_unittest.cc

Issue 1937173002: Revert of Pepper takes ownership of a mailbox before passing it to the texture layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/texture_layer.cc ('k') | components/mus/gles2/command_buffer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/texture_layer_unittest.cc
diff --git a/cc/layers/texture_layer_unittest.cc b/cc/layers/texture_layer_unittest.cc
index bc139cdbae49d8a902755ce5dace9cfce79b78e4..3f354274ba353565c832a99c19bb1732928385dd 100644
--- a/cc/layers/texture_layer_unittest.cc
+++ b/cc/layers/texture_layer_unittest.cc
@@ -332,6 +332,33 @@
SingleReleaseCallback::Create(test_data_.release_mailbox1_));
}
+TEST_F(TextureLayerTest, SetTextureMailboxWithoutReleaseCallback) {
+ scoped_refptr<TextureLayer> test_layer =
+ TextureLayer::CreateForMailbox(nullptr);
+ ASSERT_TRUE(test_layer.get());
+
+ // These use the same gpu::Mailbox, but different sync points.
+ TextureMailbox mailbox1(MailboxFromChar('a'), SyncTokenFromUInt(1),
+ GL_TEXTURE_2D);
+ TextureMailbox mailbox2(MailboxFromChar('a'), SyncTokenFromUInt(2),
+ GL_TEXTURE_2D);
+
+ EXPECT_CALL(*layer_tree_host_, SetNeedsCommit()).Times(AnyNumber());
+ layer_tree_host_->SetRootLayer(test_layer);
+ Mock::VerifyAndClearExpectations(layer_tree_host_.get());
+
+ // Set the mailbox the first time. It should cause a commit.
+ EXPECT_CALL(*layer_tree_host_, SetNeedsCommit()).Times(AtLeast(1));
+ test_layer->SetTextureMailboxWithoutReleaseCallback(mailbox1);
+ Mock::VerifyAndClearExpectations(layer_tree_host_.get());
+
+ // Set the mailbox again with a new sync point, as the backing texture has
+ // been updated. It should cause a new commit.
+ EXPECT_CALL(*layer_tree_host_, SetNeedsCommit()).Times(AtLeast(1));
+ test_layer->SetTextureMailboxWithoutReleaseCallback(mailbox2);
+ Mock::VerifyAndClearExpectations(layer_tree_host_.get());
+}
+
class TextureLayerMailboxHolderTest : public TextureLayerTest {
public:
TextureLayerMailboxHolderTest()
« no previous file with comments | « cc/layers/texture_layer.cc ('k') | components/mus/gles2/command_buffer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698