Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: gpu/ipc/service/gpu_command_buffer_stub.cc

Issue 1937173002: Revert of Pepper takes ownership of a mailbox before passing it to the texture layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/ipc/service/gpu_command_buffer_stub.h ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/ipc/service/gpu_command_buffer_stub.cc
diff --git a/gpu/ipc/service/gpu_command_buffer_stub.cc b/gpu/ipc/service/gpu_command_buffer_stub.cc
index 9ed1004a053ffef38a13c386d8b37ee132578f18..c533a6f460f1bb370d39b1f44d3c701ddc09b9d1 100644
--- a/gpu/ipc/service/gpu_command_buffer_stub.cc
+++ b/gpu/ipc/service/gpu_command_buffer_stub.cc
@@ -294,9 +294,8 @@
OnInitialize);
IPC_MESSAGE_HANDLER_DELAY_REPLY(GpuCommandBufferMsg_SetGetBuffer,
OnSetGetBuffer);
- IPC_MESSAGE_HANDLER(GpuCommandBufferMsg_TakeFrontBuffer, OnTakeFrontBuffer);
- IPC_MESSAGE_HANDLER(GpuCommandBufferMsg_ReturnFrontBuffer,
- OnReturnFrontBuffer);
+ IPC_MESSAGE_HANDLER(GpuCommandBufferMsg_ProduceFrontBuffer,
+ OnProduceFrontBuffer);
IPC_MESSAGE_HANDLER_DELAY_REPLY(GpuCommandBufferMsg_WaitForTokenInRange,
OnWaitForTokenInRange);
IPC_MESSAGE_HANDLER_DELAY_REPLY(GpuCommandBufferMsg_WaitForGetOffsetInRange,
@@ -708,22 +707,14 @@
Send(reply_message);
}
-void GpuCommandBufferStub::OnTakeFrontBuffer(const Mailbox& mailbox) {
- TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnTakeFrontBuffer");
+void GpuCommandBufferStub::OnProduceFrontBuffer(const Mailbox& mailbox) {
+ TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnProduceFrontBuffer");
if (!decoder_) {
- LOG(ERROR) << "Can't take front buffer before initialization.";
- return;
- }
-
- decoder_->TakeFrontBuffer(mailbox);
-}
-
-void GpuCommandBufferStub::OnReturnFrontBuffer(const Mailbox& mailbox,
- const SyncToken& sync_token,
- bool is_lost) {
- OnWaitFenceSync(sync_token.namespace_id(), sync_token.command_buffer_id(),
- sync_token.release_count());
- decoder_->ReturnFrontBuffer(mailbox, is_lost);
+ LOG(ERROR) << "Can't produce front buffer before initialization.";
+ return;
+ }
+
+ decoder_->ProduceFrontBuffer(mailbox);
}
void GpuCommandBufferStub::OnParseError() {
« no previous file with comments | « gpu/ipc/service/gpu_command_buffer_stub.h ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698