Allow SceneOverlay layers to be removed from tree

Allow SceneOverlay layers to be removed from tree

BUG=584340
Committed: https://crrev.com/11010e70e3ac7cefc61370c71c173282ad39818d
Cr-Commit-Position: refs/heads/master@{#393893}

[mdjones, 2016-05-02 21:21:05]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2016-05-02 21:21:06]

PTAL

[Theresa, 2016-05-03 00:23:09]

lgtm

https://codereview.chromium.org/1936133003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
(right):

https://codereview.chromium.org/1936133003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java:130:
return true;
nit: add a TODO note here to not always return true (with my name on it is fine
if you don't want to do it), since the tab strip gets hidden along with the
toolbar when it scrolls off. Or do it now if it's easy.

[mdjones, 2016-05-03 01:33:10]

https://codereview.chromium.org/1936133003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
(right):

https://codereview.chromium.org/1936133003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java:130:
return true;
On 2016/05/03 00:23:09, Theresa Wellington wrote:
> nit: add a TODO note here to not always return true (with my name on it is
fine
> if you don't want to do it), since the tab strip gets hidden along with the
> toolbar when it scrolls off. Or do it now if it's easy.

Done.

[mdjones, 2016-05-03 01:33:55]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2016-05-03 01:33:56]

+dfalcantara for owners

[gone, 2016-05-03 05:26:41]

OWNERS lgtm

[mdjones, 2016-05-12 17:36:58]

+cc dtrainor

[mdjones, 2016-05-16 18:26:36]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-05-16 18:26:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/1936133003/#ps20001
(title: "add todo")

[commit-bot: I haz the power, 2016-05-16 18:27:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936133003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936133003/20001

[mdjones, 2016-05-16 18:33:27]

The CQ bit was unchecked by mdjones@chromium.org

[mdjones, 2016-05-16 18:36:57]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-05-16 18:37:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936133003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936133003/20001

[commit-bot: I haz the power, 2016-05-16 19:17:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-16 19:19:07]

Description was changed from

==========
Allow SceneOverlay layers to be removed from tree

BUG=584340
==========

to

==========
Allow SceneOverlay layers to be removed from tree

BUG=584340

Committed: https://crrev.com/11010e70e3ac7cefc61370c71c173282ad39818d
Cr-Commit-Position: refs/heads/master@{#393893}
==========

[commit-bot: I haz the power, 2016-05-16 19:19:08]

Patchset 2 (id:??) landed as
https://crrev.com/11010e70e3ac7cefc61370c71c173282ad39818d
Cr-Commit-Position: refs/heads/master@{#393893}