chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java - Issue 1936133003: Allow SceneOverlay layers to be removed from tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

Issue 1936133003: Allow SceneOverlay layers to be removed from tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scene-overlay

Patch Set: add todo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

index 0266a941f5401a17c1af04faee530d48e8061dd1..8d67ebe264376ebaf0c61ab2866a85f9f7622ec8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

@@ -1166,6 +1166,9 @@ public abstract class Layout implements TabContentManager.ThumbnailChangeListene

SceneLayer content = getSceneLayer();

for (int i = 0; i < mSceneOverlays.size(); i++) {

+ // If the SceneOverlay is not showing, don't bother adding it to the tree.

+ if (!mSceneOverlays.get(i).isSceneOverlayTreeShowing()) continue;

SceneOverlayLayer overlayLayer = mSceneOverlays.get(i).getUpdatedSceneOverlayTree(

layerTitleCache, resourceManager, offsetDp);