Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4138)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java

Issue 1936133003: Allow SceneOverlay layers to be removed from tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scene-overlay
Patch Set: add todo Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
index 1c3d5fb14cadd9e53e82fcc333e232c54d46ba80..7cc8d942ad3e54cb3dae0946e25d75d418d0ac9b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
@@ -126,6 +126,13 @@ public class StripLayoutHelperManager implements SceneOverlay {
}
@Override
+ public boolean isSceneOverlayTreeShowing() {
+ // TODO(mdjones): This matches existing behavior but can be improved to return false if
+ // the top controls offset is equal to the top controls height.
+ return true;
+ }
+
+ @Override
public EventFilter getEventFilter() {
return mEventFilter;
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698