chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java - Issue 1936133003: Allow SceneOverlay layers to be removed from tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java

Issue 1936133003: Allow SceneOverlay layers to be removed from tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scene-overlay

Patch Set: add todo Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java

index b0ad4b336fdec46a56c5c4f95e05f978c63eb88e..685dcf324dc23215360e861117ae4c4f9113706d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java

@@ -30,6 +30,13 @@ public interface SceneOverlay {

ResourceManager resourceManager, float yOffset);

/**

+ * Notify the layout that a SceneOverlay is visible. If not visible, the content tree will not

+ * be modified.

+ * @return True if the SceneOverlay tree is showing.

+ */

+ boolean isSceneOverlayTreeShowing();

+ /**

* @return The {@link EventFilter} that processes events for this {@link SceneOverlay}.

EventFilter getEventFilter();