Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1935193002: [Findit] Update try-job result in a transaction and fix bugs in unittests. (Closed)

Created:
4 years, 7 months ago by stgao
Modified:
4 years, 7 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Update try-job result in a transaction and fix bugs in unittests. BUG=607956 Committed: https://chromium.googlesource.com/infra/infra/+/00689794b1ed85b90c017c2a12a0a67a04d7daa0

Patch Set 1 #

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M appengine/findit/waterfall/identify_try_job_culprit_pipeline.py View 3 chunks +26 lines, -15 lines 0 comments Download
M appengine/findit/waterfall/monitor_try_job_pipeline.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py View 3 chunks +3 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/swarming_tasks_to_try_job_pipeline_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/try_job_pipeline_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
stgao
ptal
4 years, 7 months ago (2016-05-02 18:30:19 UTC) #2
lijeffrey
lgtm
4 years, 7 months ago (2016-05-02 19:06:42 UTC) #3
stgao
Just fix a nit.
4 years, 7 months ago (2016-05-02 19:49:43 UTC) #4
chanli
On 2016/05/02 19:49:43, stgao wrote: > Just fix a nit. lgtm
4 years, 7 months ago (2016-05-02 20:45:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935193002/20001
4 years, 7 months ago (2016-05-02 20:46:13 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 20:49:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/00689794b1ed85b90c017c2a12a0a...

Powered by Google App Engine
This is Rietveld 408576698