Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: appengine/findit/waterfall/monitor_try_job_pipeline.py

Issue 1935193002: [Findit] Update try-job result in a transaction and fix bugs in unittests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/monitor_try_job_pipeline.py
diff --git a/appengine/findit/waterfall/monitor_try_job_pipeline.py b/appengine/findit/waterfall/monitor_try_job_pipeline.py
index d0f78a2a2fc2042d0696d7be632debbf95f8b24a..bd0802ffe674dca505524c17a1aade1c996b9745 100644
--- a/appengine/findit/waterfall/monitor_try_job_pipeline.py
+++ b/appengine/findit/waterfall/monitor_try_job_pipeline.py
@@ -6,6 +6,8 @@ from datetime import datetime
import json
import time
+from google.appengine.ext import ndb
+
from common.pipeline_wrapper import BasePipeline
from common.pipeline_wrapper import pipeline
from common.waterfall import buildbucket_client
@@ -137,6 +139,7 @@ class MonitorTryJobPipeline(BasePipeline):
try_job_data.put()
+ @ndb.transactional
def _UpdateTryJobResult(
self, status, master_name, builder_name, build_number, try_job_type,
try_job_id, try_job_url, result_content=None):

Powered by Google App Engine
This is Rietveld 408576698