[Findit] Update try-job result in a transaction and fix bugs in unittests.

appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from testing_utils import testing
 
 from common.git_repository import GitRepository
 from model import analysis_status
 from model import result_status
 from model.wf_analysis import WfAnalysis
@@ skipping 448 matching lines @@
         }
     }
 
     self.assertEqual(expected_compile_result['culprit'], culprit)
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
     self.assertEqual(expected_compile_result, try_job.compile_results[-1])
     self.assertEqual(analysis_status.COMPLETED, try_job.status)
 
     try_job_data = WfTryJobData.Get(try_job_id)
+    analysis = WfAnalysis.Get(master_name, builder_name, build_number)
     self.assertEqual({'compile': expected_culprit}, try_job_data.culprits)
     self.assertEqual(analysis.result_status,
                      result_status.FOUND_UNTRIAGED)
     self.assertEqual(analysis.suspected_cls,
                      [expected_suspected_cl])
 
   def testIdentifyCulpritForCompileReturnNoneIfAllPassed(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
@@ skipping 177 matching lines @@
     expected_culprit = {
         'a_test': {
             'tests': {
                 'a_test1': expected_suspected_cl
             }
         }
     }
     self.assertEqual(expected_culprit, culprit)
 
     try_job_data = WfTryJobData.Get(try_job_id)
+    analysis = WfAnalysis.Get(master_name, builder_name, build_number)
     expected_culprit_data = {
         'a_test': {
             'a_test1': 'rev3'
         }
     }
     self.assertEqual(expected_culprit_data, try_job_data.culprits)
     self.assertEqual(analysis.result_status,
                      result_status.FOUND_UNTRIAGED)
     self.assertEqual(analysis.suspected_cls, [expected_suspected_cl])
 
@@ skipping 133 matching lines @@
         }
     }
 
     self.assertEqual(expected_test_result['culprit'], culprit)
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
     self.assertEqual(expected_test_result, try_job.test_results[-1])
     self.assertEqual(analysis_status.COMPLETED, try_job.status)
 
     try_job_data = WfTryJobData.Get(try_job_id)
+    analysis = WfAnalysis.Get(master_name, builder_name, build_number)
     expected_culprit_data = {
         'a_test': {
             'a_test1': 'rev1',
             'a_test2': 'rev2',
         },
         'b_test': {
             'b_test1': 'rev1',
         },
         'c_test': 'rev2'
         }
@@ skipping 46 matching lines @@
     try_job.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     pipeline.run(master_name, builder_name, build_number, ['rev1'],
                  TryJobType.COMPILE, '1', compile_result)
 
     self.assertEqual(analysis.result_status,
                      result_status.FOUND_UNTRIAGED)
     self.assertEqual(analysis.suspected_cls, [suspected_cl])
     self.assertEqual(version, analysis.version)  # No update to analysis.