appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py - Issue 1935193002: [Findit] Update try-job result in a transaction and fix bugs in unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

Issue 1935193002: [Findit] Update try-job result in a transaction and fix bugs in unittests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Fix nit. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/monitor_try_job_pipeline.py ('k') | appengine/findit/waterfall/test/swarming_tasks_to_try_job_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

index 0eb3a6ccde753cd76f21ccfc4eca60305f941f69..5befaa6ca78d221191987120ef2e30068f1f1bc4 100644

--- a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

+++ b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

@@ -466,6 +466,7 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):

self.assertEqual(analysis_status.COMPLETED, try_job.status)

try_job_data = WfTryJobData.Get(try_job_id)

+ analysis = WfAnalysis.Get(master_name, builder_name, build_number)

self.assertEqual({'compile': expected_culprit}, try_job_data.culprits)

self.assertEqual(analysis.result_status,

result_status.FOUND_UNTRIAGED)

@@ -663,6 +664,7 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):

self.assertEqual(expected_culprit, culprit)

try_job_data = WfTryJobData.Get(try_job_id)

+ analysis = WfAnalysis.Get(master_name, builder_name, build_number)

expected_culprit_data = {

'a_test': {

'a_test1': 'rev3'

@@ -816,6 +818,7 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):

self.assertEqual(analysis_status.COMPLETED, try_job.status)

try_job_data = WfTryJobData.Get(try_job_id)

+ analysis = WfAnalysis.Get(master_name, builder_name, build_number)

expected_culprit_data = {

'a_test': {

'a_test1': 'rev1',