Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1934413002: Revert of x11: Don't wait on a MapNotify on override-redirect windows. (Closed)

Created:
4 years, 7 months ago by Elliot Glaysher
Modified:
4 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of x11: Don't wait on a MapNotify on override-redirect windows. (patchset #3 id:40001 of https://codereview.chromium.org/1933923002/ ) Reason for revert: Forcing a draw didn't actually fix the blank submenu issue. Original issue's description: > [reland] x11: Don't wait on a MapNotify on override-redirect windows. > > [This reland should theoretically fix a case where timing issues on > AMD drivers appear to cause a blank window by forcing a redraw when > we are an override-redirect window and receive a MapNotify.] > > Some window managers do not send MapNotify on override-redirect > windows. Enlightenment doesn't send one, XFCE does, and I don't know > which behaviour is more common. > > This makes mapping resilient against whether we would have received a > MapNotify message on override-redirect window. On override-redirect > windows, we immediately trigger the code that would run in the future > MapNotify handler, and ignore it in the future MapNotify message if it > is already run. > > BUG=381732, 606661 > First Review URL: https://codereview.chromium.org/1896363004 > > Committed: https://crrev.com/a23e0eae44653ab9f132d454ac6488c8c8005479 > Cr-Commit-Position: refs/heads/master@{#390773} TBR=danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=381732, 606661 Committed: https://crrev.com/e6184cdf538895d1ca804d1c2abb2474ec1abd54 Cr-Commit-Position: refs/heads/master@{#390989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -63 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 6 chunks +24 lines, -53 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Elliot Glaysher
Created Revert of x11: Don't wait on a MapNotify on override-redirect windows.
4 years, 7 months ago (2016-05-02 17:13:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934413002/1
4 years, 7 months ago (2016-05-02 17:14:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934413002/1
4 years, 7 months ago (2016-05-02 17:32:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 17:55:49 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:57:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6184cdf538895d1ca804d1c2abb2474ec1abd54
Cr-Commit-Position: refs/heads/master@{#390989}

Powered by Google App Engine
This is Rietveld 408576698