x11: Don't wait on a MapNotify on override-redirect windows.

[reland] x11: Don't wait on a MapNotify on override-redirect windows.

[This reland should theoretically fix a case where timing issues on
AMD drivers appear to cause a blank window by forcing a redraw when
we are an override-redirect window and receive a MapNotify.]

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732, 606661
First Review URL: https://codereview.chromium.org/1896363004

Committed: https://crrev.com/a23e0eae44653ab9f132d454ac6488c8c8005479
Cr-Commit-Position: refs/heads/master@{#390773}

[Elliot Glaysher, 2016-04-29 20:23:31]

Description was changed from

==========
x11: Don't wait on a MapNotify on override-redirect windows.

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732

Review URL: https://codereview.chromium.org/1896363004

Cr-Commit-Position: refs/heads/master@{#389572}
==========

to

==========
[reland] x11: Don't wait on a MapNotify on override-redirect windows.

[This reland should theoretically fix a case where timing issues on
AMD drivers appear to cause a blank window by forcing a redraw when
we are an override-redirect window and receive a MapNotify.]

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732,606661
First Review URL: https://codereview.chromium.org/1896363004
==========

[Elliot Glaysher, 2016-04-29 20:23:31]

erg@chromium.org changed reviewers:
+ danakj@chromium.org

[Elliot Glaysher, 2016-04-29 20:24:48]

danakj: patch 2 is all that changed.

I'm not sure of this patch; I've tested it on nvidia hardware to show that it
doesn't hurt, but I don't have any machines with amd cards in it (and don't know
how I'd acquire one), so this fix is purely speculative.

[danakj, 2016-04-29 20:50:30]

LGTM

https://codereview.chromium.org/1933923002/diff/20001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/1933923002/diff/20001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1412: // because on
AMD drivers we might get a MapNotify event after performing the
Can you link to a bug or whatever you've got for context?

[Elliot Glaysher, 2016-04-29 20:54:59]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-04-29 20:54:59]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1933923002/#ps40001
(title: "Link to bug.")

[commit-bot: I haz the power, 2016-04-29 20:55:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933923002/40001

[commit-bot: I haz the power, 2016-04-29 21:51:25]

Description was changed from

==========
[reland] x11: Don't wait on a MapNotify on override-redirect windows.

[This reland should theoretically fix a case where timing issues on
AMD drivers appear to cause a blank window by forcing a redraw when
we are an override-redirect window and receive a MapNotify.]

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732,606661
First Review URL: https://codereview.chromium.org/1896363004
==========

to

==========
[reland] x11: Don't wait on a MapNotify on override-redirect windows.

[This reland should theoretically fix a case where timing issues on
AMD drivers appear to cause a blank window by forcing a redraw when
we are an override-redirect window and receive a MapNotify.]

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732,606661
First Review URL: https://codereview.chromium.org/1896363004
==========

[commit-bot: I haz the power, 2016-04-29 21:51:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:29:21]

Patchset 3 (id:??) landed as
https://crrev.com/a23e0eae44653ab9f132d454ac6488c8c8005479
Cr-Commit-Position: refs/heads/master@{#390773}

[commit-bot: I haz the power, 2016-04-30 18:02:51]

Description was changed from

==========
[reland] x11: Don't wait on a MapNotify on override-redirect windows.

[This reland should theoretically fix a case where timing issues on
AMD drivers appear to cause a blank window by forcing a redraw when
we are an override-redirect window and receive a MapNotify.]

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732,606661
First Review URL: https://codereview.chromium.org/1896363004
==========

to

==========
[reland] x11: Don't wait on a MapNotify on override-redirect windows.

[This reland should theoretically fix a case where timing issues on
AMD drivers appear to cause a blank window by forcing a redraw when
we are an override-redirect window and receive a MapNotify.]

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732,606661
First Review URL: https://codereview.chromium.org/1896363004

Committed: https://crrev.com/a23e0eae44653ab9f132d454ac6488c8c8005479
Cr-Commit-Position: refs/heads/master@{#390773}
==========

[Elliot Glaysher, 2016-05-02 17:13:49]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1934413002/ by erg@chromium.org.

The reason for reverting is: Forcing a draw didn't actually fix the blank
submenu issue..