x11: Don't wait on a MapNotify on override-redirect windows.

x11: Don't wait on a MapNotify on override-redirect windows.

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732
Committed: https://crrev.com/28bb70402ddc4e68963f536388730c63598f8d65
Cr-Commit-Position: refs/heads/master@{#389572}

[Elliot Glaysher, 2016-04-25 19:54:11]

Description was changed from

==========
x11: Don't wait on a MapNotify on override-redirect windows.

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes (un)mapping resilient against whether we would have received
a MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732
==========

to

==========
x11: Don't wait on a MapNotify on override-redirect windows.

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732
==========

[Elliot Glaysher, 2016-04-25 21:03:01]

erg@chromium.org changed reviewers:
+ danakj@chromium.org, thomasanderson@chromium.org

[Elliot Glaysher, 2016-04-25 21:03:02]

Sadly, we still need to mark windows as hidden as synchronous due to views code
expecting this. Removing the block in most cases from mapping should be enough
to fix the bug though.

[danakj, 2016-04-25 21:29:41]

ps override redirect is evil :) and there are window types to say things like
tooltip to the WM, which will let compositing managers do nicer things too:
https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm1402004...

LGTM though, this is more correct.

[danakj, 2016-04-25 21:30:17]

On 2016/04/25 21:29:41, danakj wrote:
> ps override redirect is evil :) and there are window types to say things like
> tooltip to the WM, which will let compositing managers do nicer things too:
>
https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm1402004...
> 
> LGTM though, this is more correct.

I guess we could/should set these hints even if we use override redirect.

"This hint SHOULD also be set for override-redirect windows to allow compositing
managers to apply consistent decorations to menus, tooltips etc."

[Elliot Glaysher, 2016-04-25 21:37:24]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2016-04-25 21:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896363004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896363004/40001

[commit-bot: I haz the power, 2016-04-25 21:45:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-25 21:46:38]

Description was changed from

==========
x11: Don't wait on a MapNotify on override-redirect windows.

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732
==========

to

==========
x11: Don't wait on a MapNotify on override-redirect windows.

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG=381732

Committed: https://crrev.com/28bb70402ddc4e68963f536388730c63598f8d65
Cr-Commit-Position: refs/heads/master@{#389572}
==========

[commit-bot: I haz the power, 2016-04-25 21:46:39]

Patchset 3 (id:??) landed as
https://crrev.com/28bb70402ddc4e68963f536388730c63598f8d65
Cr-Commit-Position: refs/heads/master@{#389572}

[Elliot Glaysher, 2016-04-27 18:14:54]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1931583002/ by erg@chromium.org.

The reason for reverting is: Patch suspected to cause blank sublist on menus.

BUG=606661.

[danakj, 2016-04-27 18:51:05]

On 2016/04/27 18:14:54, Elliot Glaysher wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1931583002/ by mailto:erg@chromium.org.
> 
> The reason for reverting is: Patch suspected to cause blank sublist on menus.
> 
> BUG=606661.

I guess we need to wait for MapNotify before rendering if it's going to come,
but not if it's not? What a story.

[danakj, 2016-04-27 18:51:33]

On 2016/04/27 18:51:05, danakj wrote:
> On 2016/04/27 18:14:54, Elliot Glaysher wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/1931583002/ by mailto:erg@chromium.org.
> > 
> > The reason for reverting is: Patch suspected to cause blank sublist on
menus.
> > 
> > BUG=606661.
> 
> I guess we need to wait for MapNotify before rendering if it's going to come,
> but not if it's not? What a story.

One possibility is to damage the window when we hear it maps so we re-render it
or something. Ugh :/