Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Issue 1934413002: Revert of x11: Don't wait on a MapNotify on override-redirect windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_ 5 #ifndef UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_
6 #define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_ 6 #define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 #include <X11/extensions/shape.h> 10 #include <X11/extensions/shape.h>
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 // window size to the monitor size causes the WM to set the EWMH for 177 // window size to the monitor size causes the WM to set the EWMH for
178 // fullscreen. 178 // fullscreen.
179 gfx::Size AdjustSize(const gfx::Size& requested_size); 179 gfx::Size AdjustSize(const gfx::Size& requested_size);
180 180
181 // Called when |xwindow_|'s _NET_WM_STATE property is updated. 181 // Called when |xwindow_|'s _NET_WM_STATE property is updated.
182 void OnWMStateUpdated(); 182 void OnWMStateUpdated();
183 183
184 // Called when |xwindow_|'s _NET_FRAME_EXTENTS property is updated. 184 // Called when |xwindow_|'s _NET_FRAME_EXTENTS property is updated.
185 void OnFrameExtentsUpdated(); 185 void OnFrameExtentsUpdated();
186 186
187 // Called when |xwindow_| is mapped, either directly (in the case of
188 // override-redirect windows) or in response to a MapNotify event.
189 void OnX11WindowMapped();
190
191 // Called when |xwindow_| is unmapped.
192 void OnX11WindowUnmapped();
193
194 // Updates |xwindow_|'s minimum and maximum size. 187 // Updates |xwindow_|'s minimum and maximum size.
195 void UpdateMinAndMaxSize(); 188 void UpdateMinAndMaxSize();
196 189
197 // Updates |xwindow_|'s _NET_WM_USER_TIME if |xwindow_| is active. 190 // Updates |xwindow_|'s _NET_WM_USER_TIME if |xwindow_| is active.
198 void UpdateWMUserTime(const ui::PlatformEvent& event); 191 void UpdateWMUserTime(const ui::PlatformEvent& event);
199 192
200 // Sends a message to the x11 window manager, enabling or disabling the 193 // Sends a message to the x11 window manager, enabling or disabling the
201 // states |state1| and |state2|. 194 // states |state1| and |state2|.
202 void SetWMSpecState(bool enabled, ::Atom state1, ::Atom state2); 195 void SetWMSpecState(bool enabled, ::Atom state1, ::Atom state2);
203 196
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 282
290 // The window manager state bits. 283 // The window manager state bits.
291 std::set< ::Atom> window_properties_; 284 std::set< ::Atom> window_properties_;
292 285
293 // Whether |xwindow_| was requested to be fullscreen via SetFullscreen(). 286 // Whether |xwindow_| was requested to be fullscreen via SetFullscreen().
294 bool is_fullscreen_; 287 bool is_fullscreen_;
295 288
296 // True if the window should stay on top of most other windows. 289 // True if the window should stay on top of most other windows.
297 bool is_always_on_top_; 290 bool is_always_on_top_;
298 291
299 // True if the window has the override_redirect bit set.
300 bool is_override_redirect_;
301
302 // True if the window has title-bar / borders provided by the window manager. 292 // True if the window has title-bar / borders provided by the window manager.
303 bool use_native_frame_; 293 bool use_native_frame_;
304 294
305 // True if a Maximize() call should be done after mapping the window. 295 // True if a Maximize() call should be done after mapping the window.
306 bool should_maximize_after_map_; 296 bool should_maximize_after_map_;
307 297
308 // Whether we used an ARGB visual for our window. 298 // Whether we used an ARGB visual for our window.
309 bool use_argb_visual_; 299 bool use_argb_visual_;
310 300
311 DesktopDragDropClientAuraX11* drag_drop_client_; 301 DesktopDragDropClientAuraX11* drag_drop_client_;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 base::CancelableCallback<void()> delayed_resize_task_; 349 base::CancelableCallback<void()> delayed_resize_task_;
360 350
361 base::WeakPtrFactory<DesktopWindowTreeHostX11> close_widget_factory_; 351 base::WeakPtrFactory<DesktopWindowTreeHostX11> close_widget_factory_;
362 352
363 DISALLOW_COPY_AND_ASSIGN(DesktopWindowTreeHostX11); 353 DISALLOW_COPY_AND_ASSIGN(DesktopWindowTreeHostX11);
364 }; 354 };
365 355
366 } // namespace views 356 } // namespace views
367 357
368 #endif // UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_ 358 #endif // UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_WINDOW_TREE_HOST_X11_H_
OLDNEW
« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698