Enhance GN's "desc" command to support configs.

Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving away from these in the help and other places where we use indenting for hierarchy anyway.

Header printing is also more consistent. Previously if you asked for one variable, sometimes you would get a header and sometimes you wouldn't, depending on the type. Now it will consistently elide headers.

Committed: https://crrev.com/eda2744e306d07f7bee6a25b3961a3bcabb9de17
Cr-Commit-Position: refs/heads/master@{#392700}

[brettw, 2016-04-29 22:21:41]

Description was changed from

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

BUG=
==========

to

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

BUG=
==========

[brettw, 2016-04-29 22:22:48]

Description was changed from

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

BUG=
==========

to

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving
away from these in the help and other places where we use indenting for
hierarchy anyway.
==========

[brettw, 2016-04-29 22:23:57]

Description was changed from

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving
away from these in the help and other places where we use indenting for
hierarchy anyway.
==========

to

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving
away from these in the help and other places where we use indenting for
hierarchy anyway.

Header printing is also more consistent. Previously if you asked for one
variable, sometimes you would get a header and sometimes you wouldn't, depending
on the type. Now it will consistently elide headers.
==========

[brettw, 2016-04-29 22:41:07]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-04-29 22:41:25]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 22:41:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934003002/20001

[commit-bot: I haz the power, 2016-04-29 23:30:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 23:30:26]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-04-30 00:27:54]

I've started looking at this some, but need to look at it more.

update reference.md while you're at it ...

https://codereview.chromium.org/1934003002/diff/20001/tools/gn/command_desc.cc
File tools/gn/command_desc.cc (right):

https://codereview.chromium.org/1934003002/diff/20001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:499: // the things that match (if any). REturns true if
anything was printed.
nit: s/REturns/Returns/.

[brettw, 2016-05-02 16:31:08]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 16:31:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934003002/40001

[commit-bot: I haz the power, 2016-05-02 17:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 17:11:15]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-05-03 19:12:13]

Ping in case this fell off your list.

[brettw, 2016-05-10 16:41:17]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org
- dpranke@chromium.org

[brettw, 2016-05-10 16:41:27]

-> scottmg

[scottmg, 2016-05-10 17:40:55]

lgtm

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.cc
File tools/gn/command_desc.cc (right):

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:401: template<> struct DescValueWriter<SourceDir> {
\n before

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:406: template<> struct DescValueWriter<LibFile> {
\n before

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:504: if (what == "precompiled_header" || what.empty())
{
-> kPrecompiledHeader

You have all the what.empty()s before the what== below too.

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:512: if (what == "precompiled_source" || what.empty())
{
same kPrecompiledSource

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:543: bool is_binary_output =
Is this Target::IsBinary()? (other than UNKNOWN.) If not, make a member there
that does this.

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:607: if (what == variables::kScript) {
`what.empty() ||` and for kArgs? If not, a comment that it's too noisy or
whatever.

https://codereview.chromium.org/1934003002/diff/40001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:912: bool multiple_outputs = target_matches.size() +
config_matches.size() > 1;
I read this at first as X + (Y > 1), maybe put () around the things being added.

[brettw, 2016-05-10 18:24:52]

review

[brettw, 2016-05-10 18:24:53]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-05-10 18:24:53]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1934003002/#ps60001
(title: "review")

[commit-bot: I haz the power, 2016-05-10 18:25:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934003002/60001

[commit-bot: I haz the power, 2016-05-10 18:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 18:34:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottmg, 2016-05-10 18:59:39]

https://codereview.chromium.org/1934003002/diff/60001/tools/gn/command_desc.cc
File tools/gn/command_desc.cc (right):

https://codereview.chromium.org/1934003002/diff/60001/tools/gn/command_desc.c...
tools/gn/command_desc.cc:605: if (what/empty() || what == variables::kArgs) {
I suspect this might be incorrect. :p

[brettw, 2016-05-10 19:09:34]

typos

[brettw, 2016-05-10 19:09:35]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-05-10 19:09:36]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1934003002/#ps80001
(title: "typos")

[commit-bot: I haz the power, 2016-05-10 19:10:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934003002/80001

[commit-bot: I haz the power, 2016-05-10 20:32:09]

Description was changed from

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving
away from these in the help and other places where we use indenting for
hierarchy anyway.

Header printing is also more consistent. Previously if you asked for one
variable, sometimes you would get a header and sometimes you wouldn't, depending
on the type. Now it will consistently elide headers.
==========

to

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving
away from these in the help and other places where we use indenting for
hierarchy anyway.

Header printing is also more consistent. Previously if you asked for one
variable, sometimes you would get a header and sometimes you wouldn't, depending
on the type. Now it will consistently elide headers.
==========

[commit-bot: I haz the power, 2016-05-10 20:32:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-10 20:33:06]

Description was changed from

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving
away from these in the help and other places where we use indenting for
hierarchy anyway.

Header printing is also more consistent. Previously if you asked for one
variable, sometimes you would get a header and sometimes you wouldn't, depending
on the type. Now it will consistently elide headers.
==========

to

==========
Enhance GN's "desc" command to support configs.

Reworks the flow to duplicate things a bit less in the "overview output" and
"one thing" output mode.

Supports wildcards in the output like most other introspection commands.

Consolidates help and switch value for "all-toolchains"

Removed colons from desc headings. These were inconsistent and I've been moving
away from these in the help and other places where we use indenting for
hierarchy anyway.

Header printing is also more consistent. Previously if you asked for one
variable, sometimes you would get a header and sometimes you wouldn't, depending
on the type. Now it will consistently elide headers.

Committed: https://crrev.com/eda2744e306d07f7bee6a25b3961a3bcabb9de17
Cr-Commit-Position: refs/heads/master@{#392700}
==========

[commit-bot: I haz the power, 2016-05-10 20:33:07]

Patchset 5 (id:??) landed as
https://crrev.com/eda2744e306d07f7bee6a25b3961a3bcabb9de17
Cr-Commit-Position: refs/heads/master@{#392700}