Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: tools/gn/command_ls.cc

Issue 1934003002: Enhance GN's "desc" command to support configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typos Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/command_refs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_ls.cc
diff --git a/tools/gn/command_ls.cc b/tools/gn/command_ls.cc
index eddb51c379779445e164748bb99c028bdcda5b9c..c9b9672cf80aabffc906b3670e2d0bfd8f891d6c 100644
--- a/tools/gn/command_ls.cc
+++ b/tools/gn/command_ls.cc
@@ -10,6 +10,7 @@
#include "tools/gn/label_pattern.h"
#include "tools/gn/setup.h"
#include "tools/gn/standard_out.h"
+#include "tools/gn/switches.h"
#include "tools/gn/target.h"
namespace commands {
@@ -34,11 +35,7 @@ const char kLs_Help[] =
"\n"
TARGET_PRINTING_MODE_COMMAND_LINE_HELP
"\n"
- " --all-toolchains\n"
- " Matches all toolchains. When set, if the label pattern does not\n"
- " specify an explicit toolchain, labels from all toolchains will be\n"
- " matched. When unset, only targets in the default toolchain will\n"
- " be matched unless an explicit toolchain in the label is set.\n"
+ ALL_TOOLCHAINS_SWITCH_HELP
"\n"
TARGET_TESTONLY_FILTER_COMMAND_LINE_HELP
"\n"
@@ -81,7 +78,7 @@ int RunLs(const std::vector<std::string>& args) {
return 1;
const base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
- bool all_toolchains = cmdline->HasSwitch("all-toolchains");
+ bool all_toolchains = cmdline->HasSwitch(switches::kAllToolchains);
std::vector<const Target*> matches;
if (args.size() > 1) {
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/command_refs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698