Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: tools/gn/config_values.h

Issue 1934003002: Enhance GN's "desc" command to support configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typos Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_refs.cc ('k') | tools/gn/docs/reference.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/config_values.h
diff --git a/tools/gn/config_values.h b/tools/gn/config_values.h
index b24ae2120ec9d6604cb74ad9fc2818f6ac6c9018..af97c2bc62cdbf2542abd8b63695850a19372511 100644
--- a/tools/gn/config_values.h
+++ b/tools/gn/config_values.h
@@ -30,9 +30,10 @@ class ConfigValues {
const std::vector<SourceDir>& name() const { return name##_; } \
std::vector<SourceDir>& name() { return name##_; }
- // ==================================================================
- // IMPORTANT: If you add a new one, be sure to update AppendValues().
- // ==================================================================
+ // =================================================================
+ // IMPORTANT: If you add a new one, be sure to update AppendValues()
+ // and command_desc.cc.
+ // =================================================================
STRING_VALUES_ACCESSOR(arflags)
STRING_VALUES_ACCESSOR(asmflags)
STRING_VALUES_ACCESSOR(cflags)
@@ -44,9 +45,10 @@ class ConfigValues {
DIR_VALUES_ACCESSOR (include_dirs)
STRING_VALUES_ACCESSOR(ldflags)
DIR_VALUES_ACCESSOR (lib_dirs)
- // ==================================================================
- // IMPORTANT: If you add a new one, be sure to update AppendValues().
- // ==================================================================
+ // =================================================================
+ // IMPORTANT: If you add a new one, be sure to update AppendValues()
+ // and command_desc.cc.
+ // =================================================================
#undef STRING_VALUES_ACCESSOR
#undef DIR_VALUES_ACCESSOR
« no previous file with comments | « tools/gn/command_refs.cc ('k') | tools/gn/docs/reference.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698