Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/gn/command_refs.cc

Issue 1934003002: Enhance GN's "desc" command to support configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typos Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_ls.cc ('k') | tools/gn/config_values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_refs.cc
diff --git a/tools/gn/command_refs.cc b/tools/gn/command_refs.cc
index 821fd88d7e982df203a9d2850a71c51e068ac072..413a98f89c74d65d84c3c56ce319fa76e90218d3 100644
--- a/tools/gn/command_refs.cc
+++ b/tools/gn/command_refs.cc
@@ -17,6 +17,7 @@
#include "tools/gn/item.h"
#include "tools/gn/setup.h"
#include "tools/gn/standard_out.h"
+#include "tools/gn/switches.h"
#include "tools/gn/target.h"
namespace commands {
@@ -315,16 +316,7 @@ const char kRefs_Help[] =
"\n"
" When used with --tree, turns off eliding to show a complete tree.\n"
"\n"
- " --all-toolchains\n"
- " Normally only inputs in the default toolchain will be included.\n"
- " This switch will turn on matching all toolchains.\n"
- "\n"
- " For example, a file is in a target might be compiled twice:\n"
- " once in the default toolchain and once in a secondary one. Without\n"
- " this flag, only the default toolchain one will be matched and\n"
- " printed (potentially with its recursive dependencies, depending on\n"
- " the other options). With this flag, both will be printed\n"
- " (potentially with both of their recursive dependencies).\n"
+ ALL_TOOLCHAINS_SWITCH_HELP
"\n"
TARGET_PRINTING_MODE_COMMAND_LINE_HELP
"\n"
@@ -397,7 +389,7 @@ int RunRefs(const std::vector<std::string>& args) {
const base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
bool tree = cmdline->HasSwitch("tree");
bool all = cmdline->HasSwitch("all");
- bool all_toolchains = cmdline->HasSwitch("all-toolchains");
+ bool all_toolchains = cmdline->HasSwitch(switches::kAllToolchains);
Setup* setup = new Setup;
setup->build_settings().set_check_for_bad_items(false);
« no previous file with comments | « tools/gn/command_ls.cc ('k') | tools/gn/config_values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698