Store separator info of counters as CSSStringValue

Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so
prefer storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter

Committed: https://crrev.com/c58569e4a11e639da68e6442ce8e40bdc835ba00
Cr-Commit-Position: refs/heads/master@{#391869}

[rwlbuis, 2016-04-29 17:33:52]

Patchset #2 (id:20001) has been deleted

[rwlbuis, 2016-05-05 02:32:45]

Description was changed from

==========
counter WIP

BUG=
==========

to

==========
Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so prefer
storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter
==========

[rwlbuis, 2016-05-05 02:33:34]

Description was changed from

==========
Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so prefer
storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter
==========

to

==========
Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so
prefer storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter
==========

[rwlbuis, 2016-05-05 02:34:34]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-05-05 02:34:35]

PTAL.

[Timothy Loh, 2016-05-05 04:52:46]

lgtm, but we should update CSSCounterValue::customCSSText to just call
m_separator->cssText() instead of using the serializeString function directly.

[rwlbuis, 2016-05-05 14:59:21]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-05-05 14:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1933713002/#ps40001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-05-05 14:59:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933713002/40001

[commit-bot: I haz the power, 2016-05-05 15:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 15:04:28]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[rwlbuis, 2016-05-05 15:21:10]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-05-05 15:21:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933713002/40001

[rwlbuis, 2016-05-05 15:22:19]

On 2016/05/05 04:52:46, Timothy Loh wrote:
> lgtm, but we should update CSSCounterValue::customCSSText to just call
> m_separator->cssText() instead of using the serializeString function directly.

I considered that and somehow didn't go through with it. But indeed that seems
better, I updated the patch.

[commit-bot: I haz the power, 2016-05-05 19:33:26]

Description was changed from

==========
Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so
prefer storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter
==========

to

==========
Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so
prefer storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter
==========

[commit-bot: I haz the power, 2016-05-05 19:33:27]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-05 19:34:29]

Description was changed from

==========
Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so
prefer storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter
==========

to

==========
Store separator info of counters as CSSStringValue

According to [1] the separator part of counters() is a <string>, so
prefer storing it as a CSSStringValue.

[1] https://drafts.csswg.org/css-lists-3/#funcdef-counter

Committed: https://crrev.com/c58569e4a11e639da68e6442ce8e40bdc835ba00
Cr-Commit-Position: refs/heads/master@{#391869}
==========

[commit-bot: I haz the power, 2016-05-05 19:34:31]

Patchset 2 (id:??) landed as
https://crrev.com/c58569e4a11e639da68e6442ce8e40bdc835ba00
Cr-Commit-Position: refs/heads/master@{#391869}