third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1933713002: Store separator info of counters as CSSStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1933713002: Store separator info of counters as CSSStringValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSCounterValue.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 88e679acc1c70121e23ba33dbc810cf23e8edb7b..8574c6fcade57f7893c4a8d09b6f22ae9a85248a 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1137,7 +1137,7 @@ static CSSValue* valueForContentData(const ComputedStyle& style)

const CounterContent* counter = toCounterContentData(contentData)->counter();

ASSERT(counter);

CSSCustomIdentValue* identifier = CSSCustomIdentValue::create(counter->identifier());

- CSSCustomIdentValue* separator = CSSCustomIdentValue::create(counter->separator());

+ CSSStringValue* separator = CSSStringValue::create(counter->separator());

CSSValueID listStyleIdent = CSSValueNone;

if (counter->listStyle() != NoneListStyle)

listStyleIdent = static_cast<CSSValueID>(CSSValueDisc + counter->listStyle());