Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 1933713002: Store separator info of counters as CSSStringValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index 13aee59f4f2177db8ac9250e37b9afe023c390d3..565127705adba3e30bfe5e08269ffabb5055a199 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -2382,16 +2382,13 @@ static CSSValue* consumeCounterContent(CSSParserTokenRange args, bool counters)
if (!identifier)
return nullptr;
- // TODO(timloh): Make this a CSSStringValue.
- CSSCustomIdentValue* separator = nullptr;
+ CSSStringValue* separator = nullptr;
if (!counters) {
- separator = CSSCustomIdentValue::create(String());
+ separator = CSSStringValue::create(String());
} else {
- if (!consumeCommaIncludingWhitespace(args))
- return nullptr;
- if (args.peek().type() != StringToken)
+ if (!consumeCommaIncludingWhitespace(args) || args.peek().type() != StringToken)
return nullptr;
- separator = CSSCustomIdentValue::create(args.consumeIncludingWhitespace().value());
+ separator = CSSStringValue::create(args.consumeIncludingWhitespace().value());
}
CSSPrimitiveValue* listStyle = nullptr;
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698