third_party/WebKit/Source/core/css/CSSCounterValue.cpp - Issue 1933713002: Store separator info of counters as CSSStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCounterValue.cpp

Issue 1933713002: Store separator info of counters as CSSStringValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCounterValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCounterValue.cpp b/third_party/WebKit/Source/core/css/CSSCounterValue.cpp

index 70861c5a6ac607f0151f6b5cbd21b0427da67d00..07fc304628f53dc15dbbf7638c33002b477dca40 100644

--- a/third_party/WebKit/Source/core/css/CSSCounterValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCounterValue.cpp

@@ -20,7 +20,7 @@ String CSSCounterValue::customCSSText() const

result.append(identifier());

if (!separator().isEmpty()) {

result.appendLiteral(", ");

- result.append(serializeString(separator()));

+ result.append(m_separator->cssText());

}

bool isDefaultListStyle = listStyle() == CSSValueDecimal;

if (!isDefaultListStyle) {