Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1933303002: Moves windowsresizers to ash/wm/common (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves windowsresizers to ash/wm/common And supporting code needed for the resizers/layoutmanagers. BUG=603369 TEST=covered by tests Committed: https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced Cr-Commit-Position: refs/heads/master@{#390953}

Patch Set 1 #

Patch Set 2 : WorkspaceWindowResizer #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -4056 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 4 chunks +14 lines, -14 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/common/dock/docked_window_resizer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/dock/docked_window_resizer.cc View 6 chunks +19 lines, -16 lines 0 comments Download
A + ash/wm/common/panels/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/wm/common/panels/panel_layout_manager.h View 3 chunks +3 lines, -6 lines 0 comments Download
A + ash/wm/common/panels/panel_layout_manager.cc View 13 chunks +45 lines, -51 lines 0 comments Download
A + ash/wm/common/panels/panel_window_resizer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/panels/panel_window_resizer.cc View 3 chunks +12 lines, -13 lines 0 comments Download
A + ash/wm/common/workspace/magnetism_matcher.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + ash/wm/common/workspace/magnetism_matcher.cc View 4 chunks +8 lines, -12 lines 0 comments Download
A + ash/wm/common/workspace/phantom_window_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/workspace/phantom_window_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + ash/wm/common/workspace/two_step_edge_cycler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/workspace/two_step_edge_cycler.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A + ash/wm/common/workspace/workspace_window_resizer.h View 1 4 chunks +7 lines, -8 lines 0 comments Download
A + ash/wm/common/workspace/workspace_window_resizer.cc View 1 18 chunks +45 lines, -65 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/dock/docked_window_resizer.h View 1 chunk +0 lines, -101 lines 0 comments Download
D ash/wm/dock/docked_window_resizer.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/panels/panel_layout_manager.h View 1 chunk +0 lines, -217 lines 0 comments Download
D ash/wm/panels/panel_layout_manager.cc View 1 chunk +0 lines, -906 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/panels/panel_window_resizer.h View 1 chunk +0 lines, -87 lines 0 comments Download
D ash/wm/panels/panel_window_resizer.cc View 1 chunk +0 lines, -203 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/workspace/magnetism_matcher.h View 1 chunk +0 lines, -192 lines 0 comments Download
D ash/wm/workspace/magnetism_matcher.cc View 1 chunk +0 lines, -191 lines 0 comments Download
M ash/wm/workspace/magnetism_matcher_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/workspace/phantom_window_controller.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ash/wm/workspace/phantom_window_controller.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D ash/wm/workspace/two_step_edge_cycler.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ash/wm/workspace/two_step_edge_cycler.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 1 chunk +0 lines, -231 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 1 chunk +0 lines, -1042 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sky
The only non-move (and non-format) related change is in PanelLayoutManager where I had some dead ...
4 years, 7 months ago (2016-04-29 16:43:18 UTC) #2
James Cook
LGTM with one question https://codereview.chromium.org/1933303002/diff/20001/ash/wm/workspace/magnetism_matcher_unittest.cc File ash/wm/workspace/magnetism_matcher_unittest.cc (right): https://codereview.chromium.org/1933303002/diff/20001/ash/wm/workspace/magnetism_matcher_unittest.cc#newcode1 ash/wm/workspace/magnetism_matcher_unittest.cc:1: // Copyright (c) 2012 The ...
4 years, 7 months ago (2016-04-29 20:33:19 UTC) #3
sky
On 2016/04/29 20:33:19, James Cook wrote: > LGTM with one question > > https://codereview.chromium.org/1933303002/diff/20001/ash/wm/workspace/magnetism_matcher_unittest.cc > ...
4 years, 7 months ago (2016-05-02 14:55:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933303002/20001
4 years, 7 months ago (2016-05-02 14:55:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 15:44:43 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 15:45:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced
Cr-Commit-Position: refs/heads/master@{#390953}

Powered by Google App Engine
This is Rietveld 408576698