ash/wm/workspace/magnetism_matcher_unittest.cc - Issue 1933303002: Moves windowsresizers to ash/wm/common

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/wm/workspace/magnetism_matcher_unittest.cc

Issue 1933303002: Moves windowsresizers to ash/wm/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: WorkspaceWindowResizer Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ash/wm/workspace/magnetism_matcher.cc ('k') | ash/wm/workspace/multi_window_resize_controller.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	James Cook 2016/04/29 20:33:19 Can this unit test also move into ash/wm/common? Can this unit test also move into ash/wm/common? More generally, what's the plan for existing unit tests? It seems like most of them have lots of aura dependencies. Is the plan to port them after ash/wm/common is its own component? (I had a lot of trouble with tests while building app_shell -- some of the tests never got moved from c/b/extensions to extensions/browser because of test dependencies.)
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/wm/workspace/magnetism_matcher.h"	5 #include "ash/wm/common/workspace/magnetism_matcher.h"

6	6

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8	8

9 namespace ash {	9 namespace ash {

10	10

11 // Trivial test case verifying assertions on left edge.	11 // Trivial test case verifying assertions on left edge.

12 TEST(MagnetismMatcherTest, TrivialLeft) {	12 TEST(MagnetismMatcherTest, TrivialLeft) {

13 const int distance = MagnetismMatcher::kMagneticDistance;	13 const int distance = MagnetismMatcher::kMagneticDistance;

14 const gfx::Rect initial_bounds(20, 10, 50, 60);	14 const gfx::Rect initial_bounds(20, 10, 50, 60);

15 MagnetismMatcher matcher(initial_bounds, kAllMagnetismEdges);	15 MagnetismMatcher matcher(initial_bounds, kAllMagnetismEdges);

(...skipping 144 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
160 // Should match the following which extends into non-overlapping region.	160 // Should match the following which extends into non-overlapping region.

161 EXPECT_TRUE(matcher.ShouldAttach(	161 EXPECT_TRUE(matcher.ShouldAttach(

162 gfx::Rect(initial_bounds.x() - 4,	162 gfx::Rect(initial_bounds.x() - 4,

163 140, 3, 20), &edge));	163 140, 3, 20), &edge));

164 EXPECT_EQ(MAGNETISM_EDGE_LEFT, edge.primary_edge);	164 EXPECT_EQ(MAGNETISM_EDGE_LEFT, edge.primary_edge);

165 EXPECT_EQ(SECONDARY_MAGNETISM_EDGE_NONE, edge.secondary_edge);	165 EXPECT_EQ(SECONDARY_MAGNETISM_EDGE_NONE, edge.secondary_edge);

166 }	166 }

167	167

168 } // namespace ash	168 } // namespace ash

169	169

OLD	NEW