Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1933013002: [Media Router WebUI] Remove unnecessary default property values. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Remove unnecessary default property values. This change removes default property values if we don't need them at render time. This cuts down initial load time because we avoid unnecessary function (e.g. observer) calls or data binding in the DOM when we only have a placeholder value. The extra calls/bindings happen when properties are set. On a Linux machine using a debug build, the UI load time is: - before change: 3533.77ms (average 20 runs) - after charge: 3468.72ms (average 20 runs) There is a 1.8% decrease in initial load time observed. BUG=549289 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f02873962bcfd7a419e9d67e237aedfcee8e2262 Cr-Commit-Position: refs/heads/master@{#391173}

Patch Set 1 : #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Messages

Total messages: 22 (14 generated)
apacible
PTAL, thanks! This is the first of several patches using recommendations from the perf talk.
4 years, 7 months ago (2016-04-29 17:31:19 UTC) #8
imcheng
Nice! lgtm. Please verify the UI doesn't regress with this change.
4 years, 7 months ago (2016-05-02 21:41:56 UTC) #9
apacible
On 2016/05/02 21:41:56, imcheng wrote: > Nice! lgtm. Please verify the UI doesn't regress with ...
4 years, 7 months ago (2016-05-03 02:36:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933013002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933013002/80001
4 years, 7 months ago (2016-05-03 02:36:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/176519)
4 years, 7 months ago (2016-05-03 02:42:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933013002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933013002/100001
4 years, 7 months ago (2016-05-03 05:35:11 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 7 months ago (2016-05-03 05:48:42 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 05:50:05 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f02873962bcfd7a419e9d67e237aedfcee8e2262
Cr-Commit-Position: refs/heads/master@{#391173}

Powered by Google App Engine
This is Rietveld 408576698