Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6528)

Unified Diff: chrome/test/data/webui/media_router/route_details_tests.js

Issue 1933013002: [Media Router WebUI] Remove unnecessary default property values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/media_router/media_router_container_filter_tests.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/media_router/route_details_tests.js
diff --git a/chrome/test/data/webui/media_router/route_details_tests.js b/chrome/test/data/webui/media_router/route_details_tests.js
index db00144d24707d190dec4bf602188d6fb918a681..2d8d0741f9dd6ba16169181b6ef33dccbfaac771 100644
--- a/chrome/test/data/webui/media_router/route_details_tests.js
+++ b/chrome/test/data/webui/media_router/route_details_tests.js
@@ -108,18 +108,18 @@ cr.define('route_details', function() {
checkSpanText(loadTimeData.getString('stopCastingButtonText')
.toUpperCase(), 'close-route-button');
checkSpanText(
- loadTimeData.getString('startCastingButtonText'),
+ loadTimeData.getString('startCastingButtonText').toUpperCase(),
'start-casting-to-route-button');
checkSpanText('', 'route-information');
});
- // Tests when |route| is null or set.
- test('route is null or set', function() {
- // |route| is null.
- assertEquals(null, details.route);
+ // Tests when |route| is undefined or set.
+ test('route is undefined or set', function() {
+ // |route| is initially undefined.
+ assertEquals(undefined, details.route);
checkDefaultViewIsShown();
- // Set |route| to be non-null.
+ // Set |route|.
details.route = fakeRouteOne;
assertEquals(fakeRouteOne, details.route);
checkSpanText(loadTimeData.getStringF('castingActivityStatus',
« no previous file with comments | « chrome/test/data/webui/media_router/media_router_container_filter_tests.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698